Fixup of C# locations - use generic methods.

michaelnebel · michaelnebel · commit bec5f29eb18b · 2025-09-29T13:12:41.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Parameter.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Parameter.cs
@@ -117,23 +117,15 @@ public override void Populate(TextWriter trapFile)
 
             foreach (var l in Symbol.Locations)
             {
-                var location = Context.CreateLocation(l);
-                if (location is not EmptyLocation)
-                {
-                    trapFile.param_location(this, location);
-                }
+                WriteLocationToTrap(trapFile.param_location, this, Context.CreateLocation(l));
             }
 
             if (!Symbol.Locations.Any() &&
                 Symbol.ContainingSymbol is IMethodSymbol ms &&
                 ms.Name == WellKnownMemberNames.TopLevelStatementsEntryPointMethodName &&
                 ms.ContainingType.Name == WellKnownMemberNames.TopLevelStatementsEntryPointTypeName)
             {
-                var location = Context.CreateLocation();
-                if (location is not EmptyLocation)
-                {
-                    trapFile.param_location(this, location);
-                }
+                WriteLocationToTrap(trapFile.param_location, this, Context.CreateLocation());
             }
 
             if (Symbol.HasExplicitDefaultValue && Context.Defines(Symbol))

Original file line number	Diff line number	Diff line change
`@@ -117,23 +117,15 @@ public override void Populate(TextWriter trapFile)`
`117`	`117`
`118`	`118`	`foreach (var l in Symbol.Locations)`
`119`	`119`	`{`
`120`		`- var location = Context.CreateLocation(l);`
`121`		`- if (location is not EmptyLocation)`
`122`		`- {`
`123`		`- trapFile.param_location(this, location);`
`124`		`- }`
	`120`	`+ WriteLocationToTrap(trapFile.param_location, this, Context.CreateLocation(l));`
`125`	`121`	`}`
`126`	`122`
`127`	`123`	`if (!Symbol.Locations.Any() &&`
`128`	`124`	`Symbol.ContainingSymbol is IMethodSymbol ms &&`
`129`	`125`	`ms.Name == WellKnownMemberNames.TopLevelStatementsEntryPointMethodName &&`
`130`	`126`	`ms.ContainingType.Name == WellKnownMemberNames.TopLevelStatementsEntryPointTypeName)`
`131`	`127`	`{`
`132`		`- var location = Context.CreateLocation();`
`133`		`- if (location is not EmptyLocation)`
`134`		`- {`
`135`		`- trapFile.param_location(this, location);`
`136`		`- }`
	`128`	`+ WriteLocationToTrap(trapFile.param_location, this, Context.CreateLocation());`
`137`	`129`	`}`
`138`	`130`
`139`	`131`	`if (Symbol.HasExplicitDefaultValue && Context.Defines(Symbol))`