Rust: Fix type inference for library parameters

hvitved · hvitved · commit bec542f343e9 · 2025-06-03T19:06:41.000+02:00
The old logic relied on parameters having a pattern, which is not the
case for parameters extracted from library code.
diff --git a/rust/ql/lib/codeql/rust/internal/TypeInference.qll b/rust/ql/lib/codeql/rust/internal/TypeInference.qll
@@ -569,7 +569,7 @@ private module CallExprBaseMatchingInput implements MatchingInputSig {
       exists(Param p, int i, boolean inMethod |
         paramPos(this.getParamList(), p, i, inMethod) and
         dpos = TPositionalDeclarationPosition(i, inMethod) and
-        result = inferAnnotatedType(p.getPat(), path)
+        result = p.getTypeRepr().(TypeMention).resolveTypeAt(path)
       )
       or
       exists(SelfParam self |

Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ private module CallExprBaseMatchingInput implements MatchingInputSig {`
`569`	`569`	`exists(Param p, int i, boolean inMethod \|`
`570`	`570`	`paramPos(this.getParamList(), p, i, inMethod) and`
`571`	`571`	`dpos = TPositionalDeclarationPosition(i, inMethod) and`
`572`		`- result = inferAnnotatedType(p.getPat(), path)`
	`572`	`+ result = p.getTypeRepr().(TypeMention).resolveTypeAt(path)`
`573`	`573`	`)`
`574`	`574`	`or`
`575`	`575`	`exists(SelfParam self \|`