Skip to content

Commit bd2fc33

Browse files
author
Esben Sparre Andreasen
committed
JS: annotate tests with expectations
1 parent ca21539 commit bd2fc33

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

javascript/ql/test/query-tests/Declarations/DeadStoreOfProperty/real-world-examples.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
var o = f1();
33
while (f2()) {
44
if (f4()) {
5-
o.p = 42;
5+
o.p = 42; // NOT OK
66
break;
77
}
88
f5();
@@ -12,8 +12,8 @@
1212

1313
(function(){
1414
var o = f1();
15-
o.p1 = o.p1 += 42;
16-
o.p2 -= (o.p2 *= 42);
15+
o.p1 = o.p1 += 42; // NOT OK
16+
o.p2 -= (o.p2 *= 42); // NOT OK
1717
});
1818

1919
(function(){
@@ -26,7 +26,7 @@
2626
f3();
2727
} catch (e) {
2828
f4();
29-
o.p = 42;
29+
o.p = 42; // NOT OK
3030
}
3131
}
3232
o.p = 42;
@@ -35,5 +35,5 @@
3535

3636
(function(){
3737
var o = f1();
38-
o.p = f2() ? o.p = f3() : f4();
38+
o.p = f2() ? o.p = f3() : f4(); // NOT OK
3939
});

javascript/ql/test/query-tests/Declarations/DeadStoreOfProperty/tst.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
(function(){
22
var o = {};
3-
o.pure1 = 42;
3+
o.pure1 = 42; // NOT OK
44
o.pure1 = 42;
55

6-
o.pure2 = 42;
6+
o.pure2 = 42; // NOT OK
77
o.pure2 = 43;
88

99
o.impure3 = 42;
1010
f();
1111
o.impure3 = 42;
1212

13-
o.pure4 = 42;
13+
o.pure4 = 42; // NOT OK
1414
43;
1515
o.pure4 = 42;
1616

1717
o.impure5 = 42;
1818
o.impure5 = f();
1919

20-
o.pure6 = f();
20+
o.pure6 = f(); // NOT OK
2121
o.pure6 = 42;
2222

23-
o.pure7 = 42;
23+
o.pure7 = 42; // NOT OK
2424
if(x){}
2525
o.pure7 = 42;
2626

@@ -73,7 +73,7 @@
7373
o15.pure15_aliasWrite = 42;
7474

7575
var o16 = x? o: null;
76-
o.pure16_simpleAliasWrite = 42;
76+
o.pure16_simpleAliasWrite = 42; // NOT OK
7777
o16.pure16_simpleAliasWrite = 42;
7878

7979
var o17 = {
@@ -92,7 +92,7 @@
9292
o.defaulted2 = 42;
9393

9494
var o = {};
95-
o.pure18 = 42;
96-
o.pure18 = 42;
95+
o.pure18 = 42; // NOT OK
96+
o.pure18 = 42; // NOT OK
9797
o.pure18 = 42;
9898
});

0 commit comments

Comments
 (0)