Skip to content

Commit bc19473

Browse files
committed
Fixup! remove old resolveAsProvidedModule
1 parent 4c35c59 commit bc19473

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

javascript/ql/lib/semmle/javascript/Modules.qll

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -145,18 +145,6 @@ abstract class Import extends AstNode {
145145
*/
146146
Module resolveImportedPath() { result.getFile() = Resolver::resolveExpr(this.getImportedPath()) }
147147

148-
/**
149-
* Gets a module with a `@providesModule` JSDoc tag that matches
150-
* the imported path.
151-
*/
152-
private Module resolveAsProvidedModule() {
153-
exists(JSDocTag tag |
154-
tag.getTitle() = "providesModule" and
155-
tag.getParent().getComment().getTopLevel() = result and
156-
tag.getDescription().trim() = this.getImportedPath().getValue()
157-
)
158-
}
159-
160148
/**
161149
* DEPRECATED. Use `getImportedModule()` instead.
162150
*/
@@ -180,10 +168,7 @@ abstract class Import extends AstNode {
180168
Stages::Imports::ref() and
181169
if exists(this.resolveExternsImport())
182170
then result = this.resolveExternsImport()
183-
else (
184-
result = this.resolveAsProvidedModule() or
185-
result = this.resolveImportedPath()
186-
)
171+
else result = this.resolveImportedPath()
187172
}
188173

189174
/**

0 commit comments

Comments
 (0)