Swift: Add a more realistic test case as well.

geoffw0 · geoffw0 · commit b8d29e8fc18d · 2023-08-31T15:46:47.000+01:00
diff --git a/swift/ql/test/library-tests/dataflow/flowsources/uikit.swift b/swift/ql/test/library-tests/dataflow/flowsources/uikit.swift
@@ -70,7 +70,12 @@ class MyUITextFieldDelegate : UITextFieldDelegate {
 	}
 }
 
-func test(textField: UITextField, searchTextField: UISearchTextField, myTextInput: MyTextInput, range: UITextRange) {
+func test(
+    textField: UITextField,
+    searchTextField: UISearchTextField,
+    myTextInput: MyTextInput,
+    range: UITextRange,
+    protocolTextInput: UITextInput) {
   _ = textField.text // $ source=local
   _ = textField.attributedText // $ source=local
   _ = textField.placeholder // GOOD (not input)
@@ -79,4 +84,7 @@ func test(textField: UITextField, searchTextField: UISearchTextField, myTextInpu
 
   _ = myTextInput.text(in: range)! // $ source=local
   _ = myTextInput.harmless(in: range)! // GOOD (not input)
+
+  let str = protocolTextInput.text(in: range)! // $ source=local
+  sink(arg: str) // $ MISSING: tainted
 }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,12 @@ class MyUITextFieldDelegate : UITextFieldDelegate {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`73`		`-func test(textField: UITextField, searchTextField: UISearchTextField, myTextInput: MyTextInput, range: UITextRange) {`
	`73`	`+func test(`
	`74`	`+ textField: UITextField,`
	`75`	`+ searchTextField: UISearchTextField,`
	`76`	`+ myTextInput: MyTextInput,`
	`77`	`+ range: UITextRange,`
	`78`	`+ protocolTextInput: UITextInput) {`
`74`	`79`	`_ = textField.text // $ source=local`
`75`	`80`	`_ = textField.attributedText // $ source=local`
`76`	`81`	`_ = textField.placeholder // GOOD (not input)`
`@@ -79,4 +84,7 @@ func test(textField: UITextField, searchTextField: UISearchTextField, myTextInpu`
`79`	`84`
`80`	`85`	`_ = myTextInput.text(in: range)! // $ source=local`
`81`	`86`	`_ = myTextInput.harmless(in: range)! // GOOD (not input)`
	`87`	`+`
	`88`	`+ let str = protocolTextInput.text(in: range)! // $ source=local`
	`89`	`+ sink(arg: str) // $ MISSING: tainted`
`82`	`90`	`}`