Convert to inline expectations test

Author: owen-mc

java/ql/test/query-tests/security/CWE-367/semmle/tests/TOCTOURace.qlref

@@ -1 +1,2 @@
-Security/CWE/CWE-367/TOCTOURace.ql
+query: Security/CWE/CWE-367/TOCTOURace.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

java/ql/test/query-tests/security/CWE-367/semmle/tests/Test.java

@@ -4,39 +4,39 @@
 
 class Test {
 	public final Object lock = new Object();
-	
+
 	public volatile boolean aField = true;
-	
+
 	public synchronized void bad1(Resource r) {
 		// probably used concurrently due to synchronization
 		if (r.getState()) {
-			r.act();
+			r.act(); // $ Alert
 		}
 	}
 
 	public synchronized void bad2(Resource2 r) {
 		// probably used concurrently due to synchronization
 		if (r.getState()) {
-			r.act();
+			r.act(); // $ Alert
 		}
 	}
 
 	public void bad3(Resource r) {
 		// probably used concurrently due to use of volatile field
 		if (r.getState() && aField) {
-			r.act();
+			r.act(); // $ Alert
 		}
 	}
 
 	public void bad4(Resource r) {
 		// probably used concurrently due to synchronization
 		synchronized(this) {
 			if (r.getState() && aField) {
-				r.act();
+				r.act(); // $ Alert
 			}
 		}
 	}
-	
+
 	public void good1(Resource r) {
 		// synchronizes on the same monitor as the called methods
 		synchronized(r) {
@@ -45,15 +45,15 @@ public void good1(Resource r) {
 			}
 		}
 	}
-	
+
 	public Resource rField = new Resource();
-	
+
 	public void someOtherMethod() {
 		synchronized(lock) {
 			rField.act();
 		}
 	}
-	
+
 	public void good2() {
 		// r is always guarded with the same lock, so okay
 		synchronized(lock) {
@@ -77,43 +77,43 @@ public void good3(Resource r) {
 			r.act();
 		}
 	}
-	
+
 	class Resource {
 		boolean state;
-		
+
 		public synchronized void setState(boolean newState) {
 			this.state = newState;
 		}
-		
+
 		public synchronized boolean getState() {
 			return state;
 		}
-		
+
 		public synchronized void act() {
 			if (state)
 				sideEffect();
 			else
 				sideEffect();
 		}
-		
+
 		public void sideEffect() { }
 	}
 
 	class Resource2 {
 		boolean state;
-		
+
 		public void setState(boolean newState) {
 			synchronized(this) {
 				this.state = newState;
 			}
 		}
-		
+
 		public boolean getState() {
 			synchronized(this) {
 				return state;
 			}
 		}
-		
+
 		public void act() {
 			synchronized(this) {
 				if (state)
@@ -122,7 +122,7 @@ public void act() {
 					sideEffect();
 			}
 		}
-		
+
 		public void sideEffect() { }
 	}
 }