C#: Remove getUrl() predicates

As described on https://lgtm.com/help/ql/locations#providing-location-information,
there is no need to provide a `getUrl()` predicate, when there is a `getLocation()`
predicate. Not only is it redundant, but it can also be slow because of string
construction.

Author: hvitved

csharp/ql/src/semmle/code/cil/Type.qll

@@ -23,7 +23,6 @@ class Namespace extends DotNet::Namespace, TypeContainer, @namespace {
   override Namespace getParent() { result = this.getParentNamespace() }
   override Namespace getParentNamespace() { parent_namespace(this, result) }
   override string getName() { namespaces(this,result) }
-  string getUrl() { result="" }
   override Location getLocation() { none() }
 }
 

csharp/ql/src/semmle/code/csharp/Location.qll

@@ -37,24 +37,16 @@ class Location extends @location
   string toString() { none() }
 
   /** Gets the start line of this location. */
-  int getStartLine() {
-     locations_default(this,_,result,_,_,_)
-  }
+  final int getStartLine() { this.hasLocationInfo(_, result, _, _, _) }
 
   /** Gets the end line of this location. */
-  int getEndLine() {
-     locations_default(this,_,_,_,result,_)
-  }
+  final int getEndLine() { this.hasLocationInfo(_, _, _, result, _) }
 
   /** Gets the start column of this location. */
-  int getStartColumn() {
-     locations_default(this,_,_,result,_,_)
-  }
+  final int getStartColumn() { this.hasLocationInfo(_, _, result, _, _) }
 
   /** Gets the end column of this location. */
-  int getEndColumn() {
-     locations_default(this,_,_,_,_,result)
-  }
+  final int getEndColumn() { this.hasLocationInfo(_, _, _, _, result) }
 }
 
 /**

csharp/ql/src/semmle/code/csharp/Member.qll

@@ -36,17 +36,6 @@ class Declaration extends DotNet::Declaration, Element, @declaration {
     result = this.getDeclaringType().getQualifiedName() + "." + this.toStringWithTypes()
   }
 
-  /** Define URL for declarations with no location. */
-  string getURL() {
-    if exists(this.getLocation()) then
-      exists(string path, int a, int b, int c, int d |
-        this.getLocation().hasLocationInfo(path, a, b, c, d) |
-        toUrl(path, a, b, c, d, result)
-      )
-    else
-      result = ""
-  }
-
   /**
    * Holds if this declaration has been generated by the compiler, for example
    * implicit constructors or accessors.

csharp/ql/src/semmle/code/csharp/Type.qll

@@ -751,7 +751,6 @@ class Class extends RefType, @class_type {
  * ```
  */
 class AnonymousClass extends Class {
-
   AnonymousClass() { this.getName().matches("<%") }
 }
 

csharp/ql/test/library-tests/expressions/AnonymousObjectCreation3.expected

@@ -1,2 +1,2 @@
-| expressions.cs:417:9:420:9 | object creation of type <>__AnonType0<String,String[]> |  | String[] |
-| expressions.cs:421:9:424:9 | object creation of type <>__AnonType0<String,String[]> |  | String[] |
+| expressions.cs:417:9:420:9 | object creation of type <>__AnonType0<String,String[]> | file://:0:0:0:0 | String[] |
+| expressions.cs:421:9:424:9 | object creation of type <>__AnonType0<String,String[]> | file://:0:0:0:0 | String[] |

csharp/ql/test/library-tests/namespaces/Namespaces1.expected

@@ -1 +1 @@
-|  | N1.N2 |
+| namespaces.cs:5:11:5:15 | N1.N2 |

csharp/ql/test/library-tests/namespaces/Namespaces10.expected

@@ -1 +1 @@
-|  | R1 | namespaces.cs:73:11:73:14 | A<> | namespaces.cs:80:11:80:11 | A |
+| namespaces.cs:70:11:70:12 | R1 | namespaces.cs:73:11:73:14 | A<> | namespaces.cs:80:11:80:11 | A |

csharp/ql/test/library-tests/namespaces/Namespaces2.expected

@@ -1 +1 @@
-|  | M1.M2 |
+| namespaces.cs:16:15:16:16 | M1.M2 |

csharp/ql/test/library-tests/namespaces/Namespaces3.expected

@@ -1 +1,2 @@
-|  | P1.P2 |
+| namespaces.cs:26:11:26:15 | P1.P2 |
+| namespaces.cs:33:11:33:15 | P1.P2 |

csharp/ql/test/library-tests/namespaces/Namespaces4.expected

@@ -1 +1 @@
-|  | M1.M2 |
+| namespaces.cs:16:15:16:16 | M1.M2 |