Merge pull request #14855 from tamasvajk/standalone/logMessageSink

C#: Tolerate missing call targets in LogMessageSink

Author: tamasvajk

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks/ExternalLocationSink.qll

@@ -27,8 +27,9 @@ private class ExternalModelSink extends ExternalLocationSink {
  */
 class LogMessageSink extends ExternalLocationSink {
   LogMessageSink() {
-    this.getExpr() = any(LoggerType i).getAMethod().getACall().getAnArgument()
-    or
+    this.getExpr() = any(LoggerType i).getAMethod().getACall().getAnArgument() or
+    this.getExpr() =
+      any(MethodCall call | call.getQualifier().getType() instanceof LoggerType).getAnArgument() or
     this.getExpr() =
       any(ExtensionMethodCall call |
         call.getTarget().(ExtensionMethod).getExtendedType() instanceof LoggerType

csharp/ql/test/library-tests/standalone/externalLocationSink/externalLocationSink.expected

@@ -0,0 +1,8 @@
+#select
+| standalone.cs:20:20:20:20 | access to parameter s | standalone.cs:20:20:20:20 | access to parameter s |
+| standalone.cs:25:28:25:32 | "abc" | standalone.cs:25:28:25:32 | "abc" |
+compilationErrors
+| standalone.cs:16:12:16:18 | CS0104: 'ILogger' is an ambiguous reference between 'A.ILogger' and 'B.ILogger' |
+methodCalls
+| standalone.cs:20:9:20:21 | call to method  |
+| standalone.cs:25:9:25:33 | call to method  |

csharp/ql/test/library-tests/standalone/externalLocationSink/externalLocationSink.ql

@@ -0,0 +1,10 @@
+import semmle.code.csharp.security.dataflow.flowsinks.ExternalLocationSink
+import semmle.code.csharp.commons.Diagnostics
+
+from ExternalLocationSink sink
+where sink.getLocation().getFile().fromSource()
+select sink, sink.getExpr()
+
+query predicate compilationErrors(CompilerError e) { any() }
+
+query predicate methodCalls(MethodCall m) { any() }

csharp/ql/test/library-tests/standalone/externalLocationSink/options

@@ -0,0 +1 @@
+semmle-extractor-options: --standalone

csharp/ql/test/library-tests/standalone/externalLocationSink/standalone.cs

@@ -0,0 +1,27 @@
+using A;
+using B;
+
+namespace A
+{
+    public interface ILogger { }
+}
+
+namespace B
+{
+    public interface ILogger { }
+}
+
+public class C
+{
+    public ILogger logger;
+
+    private void M(string s)
+    {
+        logger.Log(s);
+    }
+
+    private static void Main()
+    {
+        new C().logger.Log("abc");
+    }
+}