DataFlow: Remove uneeded annotation

alexet · alexet · commit aa500df31d26 · 2025-09-08T16:58:35.000+01:00
These become overlay[local] instead. This means that if dataflownode is
global, they are still global.
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -3386,7 +3386,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       )
     }
 
-    overlay[local]
     private predicate flowLocal(Node source, Node sink) =
       forceLocal(flowIncremental/2)(source, sink)
 
@@ -3408,7 +3407,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       exists(PathNode n | n.isSink() and n.getNode() = sink)
     }
 
-    overlay[local]
     private predicate flowToLocal(Node sink) = forceLocal(flowToIncremental/1)(sink)
 
     /**
@@ -3434,7 +3432,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       exists(PathNode n | n.isSource() and n.getNode() = source)
     }
 
-    overlay[local]
     private predicate flowFromLocal(Node source) = forceLocal(flowFromIncremental/1)(source)
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -3386,7 +3386,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`3386`	`3386`	`)`
`3387`	`3387`	`}`
`3388`	`3388`
`3389`		`- overlay[local]`
`3390`	`3389`	`private predicate flowLocal(Node source, Node sink) =`
`3391`	`3390`	`forceLocal(flowIncremental/2)(source, sink)`
`3392`	`3391`
`@@ -3408,7 +3407,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`3408`	`3407`	`exists(PathNode n \| n.isSink() and n.getNode() = sink)`
`3409`	`3408`	`}`
`3410`	`3409`
`3411`		`- overlay[local]`
`3412`	`3410`	`private predicate flowToLocal(Node sink) = forceLocal(flowToIncremental/1)(sink)`
`3413`	`3411`
`3414`	`3412`	`/**`
`@@ -3434,7 +3432,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`3434`	`3432`	`exists(PathNode n \| n.isSource() and n.getNode() = source)`
`3435`	`3433`	`}`
`3436`	`3434`
`3437`		`- overlay[local]`
`3438`	`3435`	`private predicate flowFromLocal(Node source) = forceLocal(flowFromIncremental/1)(source)`
`3439`	`3436`
`3440`	`3437`	`/**`