C++: Extend the files test to cover the issue with XMLParent.

geoffw0 · geoffw0 · commit a6407f00a794 · 2019-12-16T11:07:12.000Z
diff --git a/cpp/ql/test/library-tests/files/Files.expected b/cpp/ql/test/library-tests/files/Files.expected
@@ -1,4 +1,4 @@
-| c.c | library-tests/files/c.c | CFile, MetricFile | C |  |  |
-| files1.cpp | library-tests/files/files1.cpp | CppFile, MetricFile | C++ | swap | t |
-| files1.h | library-tests/files/files1.h | HeaderFile, MetricFile |  | swap |  |
-| files2.cpp | library-tests/files/files2.cpp | CppFile, MetricFile | C++ | g | x, y |
+| c.c | library-tests/files/c.c | CFile, MetricFile | C, XMLParent |  |  |
+| files1.cpp | library-tests/files/files1.cpp | CppFile, MetricFile | C++, XMLParent | swap | t |
+| files1.h | library-tests/files/files1.h | HeaderFile, MetricFile | XMLParent | swap |  |
+| files2.cpp | library-tests/files/files2.cpp | CppFile, MetricFile | C++, XMLParent | g | x, y |
diff --git a/cpp/ql/test/library-tests/files/Files.ql b/cpp/ql/test/library-tests/files/Files.ql
@@ -6,6 +6,9 @@ string describe(File f) {
   or
   f.compiledAsCpp() and
   result = "C++"
+  or
+  f instanceof XMLParent and
+  result = "XMLParent" // regression tests a bug in the constructor of XMLParent
 }
 
 from File f

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,9 @@ string describe(File f) {`
`6`	`6`	`or`
`7`	`7`	`f.compiledAsCpp() and`
`8`	`8`	`result = "C++"`
	`9`	`+ or`
	`10`	`+ f instanceof XMLParent and`
	`11`	`+ result = "XMLParent" // regression tests a bug in the constructor of XMLParent`
`9`	`12`	`}`
`10`	`13`
`11`	`14`	`from File f`