SSA: Minor perf tweak to reduce tuple duplication.

aschackmull · aschackmull · commit a4fee2e299a6 · 2025-02-18T14:01:18.000+01:00
diff --git a/shared/ssa/codeql/ssa/Ssa.qll b/shared/ssa/codeql/ssa/Ssa.qll
@@ -480,7 +480,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
       ssaDefReachesReadWithinBlock(v, def, bb, i)
       or
       ssaRef(bb, i, v, SsaActualRead()) and
-      ssaDefReachesEndOfBlock(getABasicBlockPredecessor(bb), def, v) and
+      ssaDefReachesEndOfBlock(getImmediateBasicBlockDominator(bb), def, v) and
       not ssaDefReachesReadWithinBlock(v, _, bb, i)
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {`
`480`	`480`	`ssaDefReachesReadWithinBlock(v, def, bb, i)`
`481`	`481`	`or`
`482`	`482`	`ssaRef(bb, i, v, SsaActualRead()) and`
`483`		`- ssaDefReachesEndOfBlock(getABasicBlockPredecessor(bb), def, v) and`
	`483`	`+ ssaDefReachesEndOfBlock(getImmediateBasicBlockDominator(bb), def, v) and`
`484`	`484`	`not ssaDefReachesReadWithinBlock(v, _, bb, i)`
`485`	`485`	`}`
`486`	`486`	`}`