C#: Add queries medium precision queries to the code-quality-extended suite (and update tags).

michaelnebel · michaelnebel · commit a4456cb9394b · 2025-09-05T13:49:09.000+02:00
diff --git a/csharp/ql/src/API Abuse/ClassDoesNotImplementEquals.ql b/csharp/ql/src/API Abuse/ClassDoesNotImplementEquals.ql
@@ -7,8 +7,9 @@
  * @problem.severity error
  * @precision medium
  * @id cs/class-missing-equals
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp
diff --git a/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql b/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql
@@ -7,8 +7,10 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/dispose-not-called-on-throw
- * @tags efficiency
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
+ *       performance
  *       external/cwe/cwe-404
  *       external/cwe/cwe-459
  *       external/cwe/cwe-460
diff --git a/csharp/ql/src/API Abuse/InconsistentEqualsGetHashCode.ql b/csharp/ql/src/API Abuse/InconsistentEqualsGetHashCode.ql
@@ -6,8 +6,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/inconsistent-equals-and-gethashcode
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-581
  */
 
diff --git a/csharp/ql/src/API Abuse/IncorrectCompareToSignature.ql b/csharp/ql/src/API Abuse/IncorrectCompareToSignature.ql
@@ -5,8 +5,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/wrong-compareto-signature
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp
diff --git a/csharp/ql/src/API Abuse/IncorrectEqualsSignature.ql b/csharp/ql/src/API Abuse/IncorrectEqualsSignature.ql
@@ -5,7 +5,8 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/wrong-equals-signature
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       maintainability
  */
 
diff --git a/csharp/ql/src/API Abuse/NonOverridingMethod.ql b/csharp/ql/src/API Abuse/NonOverridingMethod.ql
@@ -5,9 +5,10 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/nonoverriding-method
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       readability
- *       naming
  */
 
 import csharp
diff --git a/csharp/ql/src/ASP/SplitControlStructure.ql b/csharp/ql/src/ASP/SplitControlStructure.ql
@@ -5,8 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/asp/split-control-structure
- * @tags maintainability
- *       frameworks/asp.net
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import semmle.code.asp.AspNet
diff --git a/csharp/ql/src/Bad Practices/Comments/CommentedOutCode.ql b/csharp/ql/src/Bad Practices/Comments/CommentedOutCode.ql
@@ -5,9 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/commented-out-code
- * @tags maintainability
- *       statistical
- *       non-attributable
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/Comments/TodoComments.ql b/csharp/ql/src/Bad Practices/Comments/TodoComments.ql
@@ -6,7 +6,8 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/todo-comment
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       external/cwe/cwe-546
  */
 
diff --git a/csharp/ql/src/Bad Practices/Declarations/NoConstantsOnly.ql b/csharp/ql/src/Bad Practices/Declarations/NoConstantsOnly.ql
@@ -6,8 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/constants-only-interface
- * @tags maintainability
- *       modularity
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/ErroneousClassCompare.ql b/csharp/ql/src/Bad Practices/ErroneousClassCompare.ql
@@ -5,7 +5,8 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/class-name-comparison
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-486
  */
diff --git a/csharp/ql/src/Bad Practices/Implementation Hiding/AbstractToConcreteCollection.ql b/csharp/ql/src/Bad Practices/Implementation Hiding/AbstractToConcreteCollection.ql
@@ -7,9 +7,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/cast-from-abstract-to-concrete-collection
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-485
  */
 
diff --git a/csharp/ql/src/Bad Practices/Implementation Hiding/StaticArray.ql b/csharp/ql/src/Bad Practices/Implementation Hiding/StaticArray.ql
@@ -5,9 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/static-array
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-582
  */
 
diff --git a/csharp/ql/src/Bad Practices/Naming Conventions/ConfusingMethodNames.ql b/csharp/ql/src/Bad Practices/Naming Conventions/ConfusingMethodNames.ql
@@ -5,9 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/confusing-method-name
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       readability
- *       naming
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/Naming Conventions/ConfusingOverridesNames.ql b/csharp/ql/src/Bad Practices/Naming Conventions/ConfusingOverridesNames.ql
@@ -6,9 +6,10 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/confusing-override-name
- * @tags reliability
+ * @tags quality
+ *       maintainability
  *       readability
- *       naming
+ *       correctness
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/Naming Conventions/ControlNamePrefixes.ql b/csharp/ql/src/Bad Practices/Naming Conventions/ControlNamePrefixes.ql
@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/web/unprefixed-control-name
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/Naming Conventions/DefaultControlNames.ql b/csharp/ql/src/Bad Practices/Naming Conventions/DefaultControlNames.ql
@@ -6,8 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/forms/default-control-name
- * @tags readability
- *       naming
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/UseOfSystemOutputStream.ql b/csharp/ql/src/Bad Practices/UseOfSystemOutputStream.ql
@@ -5,7 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/console-output
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
  */
 
 import csharp
diff --git a/csharp/ql/src/Bad Practices/VirtualCallInConstructorOrDestructor.ql b/csharp/ql/src/Bad Practices/VirtualCallInConstructorOrDestructor.ql
@@ -6,9 +6,9 @@
  * @precision medium
  * @id cs/virtual-call-in-constructor
  * @alternate-ids cs/virtual-call-in-constructor-or-destructor
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp
diff --git a/csharp/ql/src/Concurrency/SynchSetUnsynchGet.ql b/csharp/ql/src/Concurrency/SynchSetUnsynchGet.ql
@@ -6,8 +6,10 @@
  * @problem.severity error
  * @precision medium
  * @id cs/unsynchronized-getter
- * @tags correctness
+ * @tags quality
+ *       reliability
  *       concurrency
+ *       correctness
  *       external/cwe/cwe-662
  */
 
diff --git a/csharp/ql/src/Concurrency/UnsafeLazyInitialization.ql b/csharp/ql/src/Concurrency/UnsafeLazyInitialization.ql
@@ -6,7 +6,8 @@
  * @problem.severity error
  * @precision medium
  * @id cs/unsafe-double-checked-lock
- * @tags correctness
+ * @tags quality
+ *       reliability
  *       concurrency
  *       external/cwe/cwe-609
  */
diff --git a/csharp/ql/src/Concurrency/UnsynchronizedStaticAccess.ql b/csharp/ql/src/Concurrency/UnsynchronizedStaticAccess.ql
@@ -6,7 +6,9 @@
  * @problem.severity error
  * @precision medium
  * @id cs/unsynchronized-static-access
- * @tags concurrency
+ * @tags quality
+ *       reliability
+ *       concurrency
  *       external/cwe/cwe-362
  *       external/cwe/cwe-567
  */
diff --git a/csharp/ql/src/Documentation/XmldocExtraParam.ql b/csharp/ql/src/Documentation/XmldocExtraParam.ql
@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/xmldoc/unknown-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import Documentation
diff --git a/csharp/ql/src/Documentation/XmldocExtraTypeParam.ql b/csharp/ql/src/Documentation/XmldocExtraTypeParam.ql
@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/xmldoc/unknown-type-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import Documentation
diff --git a/csharp/ql/src/Documentation/XmldocMissing.ql b/csharp/ql/src/Documentation/XmldocMissing.ql
@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/xmldoc/missing-xmldoc
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import Documentation
diff --git a/csharp/ql/src/Language Abuse/ForeachCapture.ql b/csharp/ql/src/Language Abuse/ForeachCapture.ql
@@ -5,9 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/captured-foreach-variable
- * @tags portability
- *       maintainability
- *       language-features
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-758
  */
 
diff --git a/csharp/ql/src/Language Abuse/UselessCastToSelf.ql b/csharp/ql/src/Language Abuse/UselessCastToSelf.ql
@@ -5,8 +5,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/useless-cast-to-self
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-561
  */
 
diff --git a/csharp/ql/src/Language Abuse/UselessIsBeforeAs.ql b/csharp/ql/src/Language Abuse/UselessIsBeforeAs.ql
@@ -5,8 +5,9 @@
  * @problem.severity recommendation
  * @precision medium
  * @id cs/useless-is-before-as
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-561
  */
 
diff --git a/csharp/ql/src/Language Abuse/UselessNullCoalescingExpression.ql b/csharp/ql/src/Language Abuse/UselessNullCoalescingExpression.ql
@@ -6,8 +6,9 @@
  * @problem.severity error
  * @precision medium
  * @id cs/coalesce-of-identical-expressions
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-561
  */
 
diff --git a/csharp/ql/src/Language Abuse/UselessTypeTest.ql b/csharp/ql/src/Language Abuse/UselessTypeTest.ql
@@ -5,8 +5,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/useless-type-test
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-561
  */
 
diff --git a/csharp/ql/src/Language Abuse/UselessUpcast.ql b/csharp/ql/src/Language Abuse/UselessUpcast.ql
@@ -5,8 +5,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/useless-upcast
- * @tags maintainability
- *       language-features
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-561
  */
 
diff --git a/csharp/ql/src/Likely Bugs/Dynamic/BadDynamicCall.ql b/csharp/ql/src/Likely Bugs/Dynamic/BadDynamicCall.ql
@@ -5,9 +5,9 @@
  * @problem.severity error
  * @precision medium
  * @id cs/invalid-dynamic-call
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
- *       logic
  *       external/cwe/cwe-628
  */
 
diff --git a/csharp/ql/src/Likely Bugs/EqualsUsesAs.ql b/csharp/ql/src/Likely Bugs/EqualsUsesAs.ql
@@ -5,8 +5,9 @@
  * @problem.severity warning
  * @precision medium
  * @id cs/equals-uses-as
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp
diff --git a/csharp/ql/src/Likely Bugs/EqualsUsesIs.ql b/csharp/ql/src/Likely Bugs/EqualsUsesIs.ql
diff --git a/csharp/ql/src/Likely Bugs/InconsistentCompareTo.ql b/csharp/ql/src/Likely Bugs/InconsistentCompareTo.ql
diff --git a/csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.ql b/csharp/ql/src/Likely Bugs/LeapYear/UnsafeYearConstruction.ql
diff --git a/csharp/ql/src/Likely Bugs/MishandlingJapaneseEra.ql b/csharp/ql/src/Likely Bugs/MishandlingJapaneseEra.ql
diff --git a/csharp/ql/src/Likely Bugs/ObjectComparison.ql b/csharp/ql/src/Likely Bugs/ObjectComparison.ql
diff --git a/csharp/ql/src/Likely Bugs/RecursiveOperatorEquals.ql b/csharp/ql/src/Likely Bugs/RecursiveOperatorEquals.ql
diff --git a/csharp/ql/src/Likely Bugs/Statements/UseBraces.ql b/csharp/ql/src/Likely Bugs/Statements/UseBraces.ql
diff --git a/csharp/ql/src/Linq/BadMultipleIteration.ql b/csharp/ql/src/Linq/BadMultipleIteration.ql
diff --git a/csharp/ql/src/Useless code/PointlessForwardingMethod.ql b/csharp/ql/src/Useless code/PointlessForwardingMethod.ql
