JS: rename ReactComponent::getAThisAccess -> getAThisNode

Author: asger-semmle

change-notes/1.19/analysis-javascript.md

@@ -38,3 +38,5 @@
 * The flow configuration framework now supports distinguishing and tracking different kinds of taint, specified by an extensible class `FlowLabel` (which can also be referred to by its alias `TaintKind`).
 
 * The `DataFlow::ThisNode` class now corresponds to the implicit receiver parameter of a function, as opposed to an indivdual `this` expression. This means `getALocalSource` now maps all `this` expressions within a given function to the same source. The data-flow node associated with a `ThisExpr` can no longer be cast to `DataFlow::SourceNode` or `DataFlow::ThisNode` - it is recomended to use `getALocalSource` before casting or instead of casting.
+
+* `ReactComponent::getAThisAccess` has been renamed to `getAThisNode`. The old name is still usable but is deprecated. It no longer gets individual `this` expressions, but the `ThisNode` mentioned above.

javascript/ql/src/semmle/javascript/frameworks/React.qll

@@ -54,10 +54,20 @@ abstract class ReactComponent extends ASTNode {
   /**
    * Gets the `this` node in an instance method of this component.
    */
-  DataFlow::SourceNode getAThisAccess() {
+  DataFlow::SourceNode getAThisNode() {
     result.(DataFlow::ThisNode).getBinder().getFunction() = getInstanceMethod(_)
   }
 
+  /**
+   * Gets the `this` node in an instance method of this component.
+   *
+   * DEPRECATED: Use `getAThisNode` instead.
+   */
+  deprecated
+  DataFlow::SourceNode getAThisAccess() {
+    result = getAThisNode()
+  }
+
   /**
    * Gets an access to the `props` object of this component.
    *