Swift: extract MissingMemberDecl

Author: redsun82

swift/extractor/translators/DeclTranslator.cpp

@@ -409,4 +409,11 @@ codeql::PoundDiagnosticDecl DeclTranslator::translatePoundDiagnosticDecl(
   entry.message = dispatcher.fetchLabel(decl.getMessage());
   return entry;
 }
+
+codeql::MissingMemberDecl DeclTranslator::translateMissingMemberDecl(
+    const swift::MissingMemberDecl& decl) {
+  auto entry = createEntry(decl);
+  entry.name = decl.getName().getBaseName().userFacingName().str();
+  return entry;
+}
 }  // namespace codeql

swift/extractor/translators/DeclTranslator.h

@@ -47,6 +47,7 @@ class DeclTranslator : public AstTranslatorBase<DeclTranslator> {
   codeql::IfConfigDecl translateIfConfigDecl(const swift::IfConfigDecl& decl);
   std::optional<codeql::OpaqueTypeDecl> translateOpaqueTypeDecl(const swift::OpaqueTypeDecl& decl);
   codeql::PoundDiagnosticDecl translatePoundDiagnosticDecl(const swift::PoundDiagnosticDecl& decl);
+  codeql::MissingMemberDecl translateMissingMemberDecl(const swift::MissingMemberDecl& decl);
 
  private:
   std::string mangledName(const swift::ValueDecl& decl);

swift/ql/lib/codeql/swift/elements/decl/MissingMemberDecl.qll

@@ -1,4 +1,5 @@
-// generated by codegen/codegen.py, remove this comment if you wish to edit this file
 private import codeql.swift.generated.decl.MissingMemberDecl
 
-class MissingMemberDecl extends Generated::MissingMemberDecl { }
+class MissingMemberDecl extends Generated::MissingMemberDecl {
+  override string toString() { result = this.getName() + " (missing)" }
+}

swift/ql/lib/codeql/swift/generated/Raw.qll

@@ -115,6 +115,8 @@ module Raw {
 
   class MissingMemberDecl extends @missing_member_decl, Decl {
     override string toString() { result = "MissingMemberDecl" }
+
+    string getName() { missing_member_decls(this, result) }
   }
 
   class OperatorDecl extends @operator_decl, Decl {

swift/ql/lib/codeql/swift/generated/decl/MissingMemberDecl.qll

@@ -4,7 +4,17 @@ private import codeql.swift.generated.Raw
 import codeql.swift.elements.decl.Decl
 
 module Generated {
+  /**
+   * A placeholder for missing declarations that can arise on object deserialization.
+   */
   class MissingMemberDecl extends Synth::TMissingMemberDecl, Decl {
     override string getAPrimaryQlClass() { result = "MissingMemberDecl" }
+
+    /**
+     * Gets the name of this missing member declaration.
+     */
+    string getName() {
+      result = Synth::convertMissingMemberDeclToRaw(this).(Raw::MissingMemberDecl).getName()
+    }
   }
 }

swift/ql/lib/swift.dbscheme

@@ -254,7 +254,8 @@ import_decl_declarations(  //dir=decl
 );
 
 missing_member_decls(  //dir=decl
-  unique int id: @missing_member_decl
+  unique int id: @missing_member_decl,
+  string name: string ref
 );
 
 @operator_decl =

swift/ql/test/extractor-tests/generated/decl/MissingMemberDecl/MISSING_SOURCE.txt

@@ -112,8 +112,10 @@ class ImportDecl(Decl):
     imported_module: optional["ModuleDecl"]
     declarations: list["ValueDecl"]
 
+@qltest.skip
 class MissingMemberDecl(Decl):
-    pass
+    """A placeholder for missing declarations that can arise on object deserialization."""
+    name: string
 
 class OperatorDecl(Decl):
     name: string