Merge pull request #9044 from michaelnebel/csharp/flowsummariestest

C#: Flow summaries test should print, whether a summary is generated or not.

Author: michaelnebel

csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll

@@ -219,6 +219,11 @@ module Public {
      */
     pragma[nomagic]
     predicate clearsContent(ParameterPosition pos, ContentSet content) { none() }
+
+    /**
+     * Holds if the summary is auto generated.
+     */
+    predicate isAutoGenerated() { none() }
   }
 }
 
@@ -898,6 +903,8 @@ module Private {
           kind = "taint" and preservesValue = false
         )
       }
+
+      override predicate isAutoGenerated() { summaryElement(this, _, _, _, true) }
     }
 
     /** Holds if component `c` of specification `spec` cannot be parsed. */
@@ -1052,9 +1059,13 @@ module Private {
       preservesValue = false and result = "taint"
     }
 
+    private string renderGenerated(RelevantSummarizedCallable c) {
+      if c.isAutoGenerated() then result = "generated:" else result = ""
+    }
+
     /**
      * A query predicate for outputting flow summaries in semi-colon separated format in QL tests.
-     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;kind",
+     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;(generated:)?kind",
      * ext is hardcoded to empty.
      */
     query predicate summary(string csv) {
@@ -1065,7 +1076,7 @@ module Private {
         c.relevantSummary(input, output, preservesValue) and
         csv =
           c.getCallableCsv() + getComponentStackCsv(input) + ";" + getComponentStackCsv(output) +
-            ";" + renderKind(preservesValue)
+            ";" + renderGenerated(c) + renderKind(preservesValue)
       )
     }
   }

java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll

@@ -219,6 +219,11 @@ module Public {
      */
     pragma[nomagic]
     predicate clearsContent(ParameterPosition pos, ContentSet content) { none() }
+
+    /**
+     * Holds if the summary is auto generated.
+     */
+    predicate isAutoGenerated() { none() }
   }
 }
 
@@ -898,6 +903,8 @@ module Private {
           kind = "taint" and preservesValue = false
         )
       }
+
+      override predicate isAutoGenerated() { summaryElement(this, _, _, _, true) }
     }
 
     /** Holds if component `c` of specification `spec` cannot be parsed. */
@@ -1052,9 +1059,13 @@ module Private {
       preservesValue = false and result = "taint"
     }
 
+    private string renderGenerated(RelevantSummarizedCallable c) {
+      if c.isAutoGenerated() then result = "generated:" else result = ""
+    }
+
     /**
      * A query predicate for outputting flow summaries in semi-colon separated format in QL tests.
-     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;kind",
+     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;(generated:)?kind",
      * ext is hardcoded to empty.
      */
     query predicate summary(string csv) {
@@ -1065,7 +1076,7 @@ module Private {
         c.relevantSummary(input, output, preservesValue) and
         csv =
           c.getCallableCsv() + getComponentStackCsv(input) + ";" + getComponentStackCsv(output) +
-            ";" + renderKind(preservesValue)
+            ";" + renderGenerated(c) + renderKind(preservesValue)
       )
     }
   }

ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImpl.qll

@@ -219,6 +219,11 @@ module Public {
      */
     pragma[nomagic]
     predicate clearsContent(ParameterPosition pos, ContentSet content) { none() }
+
+    /**
+     * Holds if the summary is auto generated.
+     */
+    predicate isAutoGenerated() { none() }
   }
 }
 
@@ -898,6 +903,8 @@ module Private {
           kind = "taint" and preservesValue = false
         )
       }
+
+      override predicate isAutoGenerated() { summaryElement(this, _, _, _, true) }
     }
 
     /** Holds if component `c` of specification `spec` cannot be parsed. */
@@ -1052,9 +1059,13 @@ module Private {
       preservesValue = false and result = "taint"
     }
 
+    private string renderGenerated(RelevantSummarizedCallable c) {
+      if c.isAutoGenerated() then result = "generated:" else result = ""
+    }
+
     /**
      * A query predicate for outputting flow summaries in semi-colon separated format in QL tests.
-     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;kind",
+     * The syntax is: "namespace;type;overrides;name;signature;ext;inputspec;outputspec;(generated:)?kind",
      * ext is hardcoded to empty.
      */
     query predicate summary(string csv) {
@@ -1065,7 +1076,7 @@ module Private {
         c.relevantSummary(input, output, preservesValue) and
         csv =
           c.getCallableCsv() + getComponentStackCsv(input) + ";" + getComponentStackCsv(output) +
-            ";" + renderKind(preservesValue)
+            ";" + renderGenerated(c) + renderKind(preservesValue)
       )
     }
   }