JS: Use RelatedLocations in UnusedOrUndefinedStateProperty

Author: asgerf

javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/issue7506.js

@@ -9,10 +9,10 @@ class C1 extends React.Component {
   }
 }
 
-class C2 extends React.Component {
+class C2 extends React.Component { // $ Alert
 
   state = {
-    p1: ''
+    p1: '' // $ RelatedLocation
   }
 
   static getDerivedStateFromProps_unmodeled(props, state) {

javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/undefined.js

@@ -1,12 +1,12 @@
-class C1 extends React.Component {
+class C1 extends React.Component { // $ Alert
     constructor() {
         this.state.writtenDirectly = 42;
         this.setState({
             writtenInSetState: 42
         });
         this.state.writtenInOtherMethod;
-        this.state.notWritten; // $ MISSING: Alert
-        this.state.notWrittenButReadInChain; // $ MISSING: Alert
+        this.state.notWritten; // $ RelatedLocation
+        this.state.notWrittenButReadInChain; // $ RelatedLocation
         this.state.writtenDirectly;
         this.state.writtenInSetState;
 
@@ -29,10 +29,10 @@ class C2 extends React.Component {
 }
 
 
-class C3 extends React.Component {
+class C3 extends React.Component { // $ Alert
     constructor() {
         this.state.writtenThrougExternalPropertyAccess;
-        this.state.notWrittenThrougExternalPropertyAccess; // $ MISSING: Alert
+        this.state.notWrittenThrougExternalPropertyAccess; // $ RelatedLocation
     }
 }
 

javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/unused.js

@@ -1,9 +1,9 @@
-class C1 extends React.Component {
+class C1 extends React.Component { // $ Alert
     constructor() {
         this.state.readDirectly = 42;
         this.state.readInChain = {};
         this.state.readInOtherMethod = {};
-        this.state.notRead = 42; // $ MISSING: Alert
+        this.state.notRead = 42; // $ RelatedLocation
         this.state.readDirectly;
         this.state.readInChain.foo;
     }
@@ -24,10 +24,10 @@ class C2 extends React.Component {
 }
 
 
-class C3 extends React.Component {
+class C3 extends React.Component { // $ Alert
     constructor() {
         this.state.readThrougExternaPropertyAccess = 42;
-        this.state.notReadThrougExternaPropertyAccess = 42; // $ MISSING: Alert
+        this.state.notReadThrougExternaPropertyAccess = 42; // $ RelatedLocation
     }
 }