Skip to content

Commit 956cb16

Browse files
committed
Remove local flow step from SSA defn to SSA capture
1 parent 9b98bcd commit 956cb16

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,6 @@ predicate basicLocalFlowStep(Node nodeFrom, Node nodeTo) {
7272
nodeTo = ssaNode(succ.getVariable())
7373
)
7474
or
75-
// SSA defn -> SSA capture
76-
exists(SsaExplicitDefinition pred, SsaVariableCapture succ |
77-
// Check: should these flow from PHIs as well? Perhaps they should be included
78-
// in the use-use graph?
79-
succ.getSourceVariable() = pred.getSourceVariable()
80-
|
81-
nodeFrom = ssaNode(pred.getVariable()) and
82-
nodeTo = ssaNode(succ.getVariable())
83-
)
84-
or
8575
// SSA defn -> first SSA use
8676
exists(SsaDefinition pred, IR::Instruction succ | succ = pred.getAFirstUse() |
8777
(pred instanceof SsaExplicitDefinition or pred instanceof SsaVariableCapture) and

0 commit comments

Comments
 (0)