Use location of elt for ImplicitLiteralElementIndexInstruction

Author: owen-mc

go/ql/lib/semmle/go/controlflow/IR.qll

@@ -647,9 +647,7 @@ module IR {
     override predicate hasLocationInfo(
       string filepath, int startline, int startcolumn, int endline, int endcolumn
     ) {
-      elt.hasLocationInfo(filepath, startline, startcolumn, _, _) and
-      endline = startline and
-      endcolumn = startcolumn
+      elt.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
     }
   }
 

go/ql/test/library-tests/semmle/go/controlflow/ControlFlowGraph/ControlFlowNode_getASuccessor.expected

@@ -171,16 +171,16 @@
 | exprs.go:15:49:15:57 | selection of x | exprs.go:15:46:15:57 | init of key-value pair |
 | exprs.go:16:2:16:5 | assignment to arr1 | exprs.go:17:2:17:5 | skip |
 | exprs.go:16:2:16:5 | skip | exprs.go:16:10:16:26 | array literal |
-| exprs.go:16:10:16:26 | array literal | exprs.go:16:17:16:17 | element index |
-| exprs.go:16:17:16:17 | element index | exprs.go:16:17:16:23 | struct3 |
+| exprs.go:16:10:16:26 | array literal | exprs.go:16:17:16:25 | element index |
 | exprs.go:16:17:16:23 | struct3 | exprs.go:16:17:16:25 | selection of x |
+| exprs.go:16:17:16:25 | element index | exprs.go:16:17:16:23 | struct3 |
 | exprs.go:16:17:16:25 | init of selection of x | exprs.go:16:2:16:5 | assignment to arr1 |
 | exprs.go:16:17:16:25 | selection of x | exprs.go:16:17:16:25 | init of selection of x |
 | exprs.go:17:2:17:5 | assignment to arr2 | exprs.go:18:2:18:4 | skip |
 | exprs.go:17:2:17:5 | skip | exprs.go:17:10:17:40 | array literal |
-| exprs.go:17:10:17:40 | array literal | exprs.go:17:19:17:19 | element index |
-| exprs.go:17:19:17:19 | element index | exprs.go:17:19:17:25 | struct3 |
+| exprs.go:17:10:17:40 | array literal | exprs.go:17:19:17:27 | element index |
 | exprs.go:17:19:17:25 | struct3 | exprs.go:17:19:17:27 | selection of x |
+| exprs.go:17:19:17:27 | element index | exprs.go:17:19:17:25 | struct3 |
 | exprs.go:17:19:17:27 | init of selection of x | exprs.go:17:30:17:30 | 2 |
 | exprs.go:17:19:17:27 | selection of x | exprs.go:17:19:17:27 | init of selection of x |
 | exprs.go:17:30:17:30 | 2 | exprs.go:17:33:17:36 | arr1 |