Skip to content

Commit 8fe1634

Browse files
committed
Java: Add test.
1 parent 1188e18 commit 8fe1634

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

java/ql/test/query-tests/security/CWE-113/semmle/tests/ResponseSplitting.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
2424
}
2525

2626
// BAD: setting a header with an unvalidated parameter
27-
// can lead to hTTP splitting
27+
// can lead to HTTP splitting
2828
response.addHeader("Content-type", request.getParameter("contentType"));
2929
response.setHeader("Content-type", request.getParameter("contentType"));
3030

@@ -42,4 +42,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
4242
private static String removeSpecial(String str) {
4343
return str.replaceAll("[^a-zA-Z ]", "");
4444
}
45+
46+
public void addCookieName(HttpServletResponse response, Cookie cookie) {
47+
// GOOD: cookie.getName() cannot lead to HTTP splitting
48+
Cookie cookie2 = new Cookie("name", cookie.getName());
49+
response.addCookie(cookie2);
50+
}
4551
}

0 commit comments

Comments
 (0)