Shared: Make sure getMadRepresentation is unique

Author: hvitved

shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll

@@ -686,6 +686,16 @@ module Make<
         derivedFluentFlowPush(_, _, _, head, tail, _)
       }
 
+    private string getUniqueMadRepresentation(SummaryComponent c) {
+      result = unique( | | c.getMadRepresentation())
+      or
+      not exists(c.getMadRepresentation()) and
+      result = "(missing)"
+      or
+      strictcount(c.getMadRepresentation()) > 1 and
+      result = "(ambigous)"
+    }
+
     /**
      * A (non-empty) stack of summary components.
      *
@@ -732,7 +742,7 @@ module Make<
         exists(SummaryComponent head, SummaryComponentStack tail |
           head = this.head() and
           tail = this.tail() and
-          result = tail.getMadRepresentation() + "." + head.getMadRepresentation()
+          result = tail.getMadRepresentation() + "." + getUniqueMadRepresentation(head)
         )
         or
         exists(SummaryComponent c |