JavaScript: Adjust alert message.

Author: Max Schaefer

javascript/ql/src/LanguageFeatures/InconsistentNew.ql

@@ -110,5 +110,6 @@ DataFlow::InvokeNode getFirstInvocation(Function f, boolean isNew) {
 from Function f, DataFlow::NewNode new, DataFlow::CallNode call
 where new = getFirstInvocation(f, true) and
       call = getFirstInvocation(f, false)
-select (FirstLineOf)f, capitalize(f.describe()) + " is invoked as a constructor $@, " +
-      "and as a normal function $@.", new, "here", call, "here"
+select (FirstLineOf)f, capitalize(f.describe()) + " is sometimes invoked as a constructor " +
+      "(for example $@), and sometimes as a normal function (for example $@).",
+      new, "here", call, "here"

javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/InconsistentNew.expected

@@ -1,2 +1,2 @@
-| m.js:1:8:1:22 | functio ...  = x;\\n} | Function A is invoked as a constructor $@, and as a normal function $@. | c1.js:2:1:2:9 | new A(42) | here | c2.js:2:1:2:5 | A(23) | here |
-| tst.js:1:1:1:22 | functio ...  = y;\\n} | Function Point is invoked as a constructor $@, and as a normal function $@. | tst.js:6:1:6:17 | new Point(23, 42) | here | tst.js:7:1:7:13 | Point(56, 72) | here |
+| m.js:1:8:1:22 | functio ...  = x;\\n} | Function A is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). | c1.js:2:1:2:9 | new A(42) | here | c2.js:2:1:2:5 | A(23) | here |
+| tst.js:1:1:1:22 | functio ...  = y;\\n} | Function Point is sometimes invoked as a constructor (for example $@), and sometimes as a normal function (for example $@). | tst.js:6:1:6:17 | new Point(23, 42) | here | tst.js:7:1:7:13 | Point(56, 72) | here |