Python: Remove manual TC from ssaShortCut.

tausbn · tausbn · commit 851d69299607 · 2020-01-06T13:40:52.000+01:00
This caused a massive slowdown on certain snapshots.
diff --git a/python/ql/src/semmle/python/pointsto/PointsTo.qll b/python/ql/src/semmle/python/pointsto/PointsTo.qll
@@ -284,7 +284,7 @@ cached module PointsToInternal {
         ssa_definition_points_to(var.getDefinition(), context, value, origin)
         or
         exists(EssaVariable prev |
-            ssaShortCut(prev, var) and
+            ssaShortCut+(prev, var) and
             variablePointsTo(prev, context, value, origin)
         )
     }
@@ -305,10 +305,6 @@ cached module PointsToInternal {
             start = def.getInput() and
             end.getDefinition() = def
         )
-        or
-        exists(EssaVariable mid |
-            ssaShortCut(start, mid) and ssaShortCut(mid, end)
-        )
     }
 
     pragma [noinline]

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ cached module PointsToInternal {`
`284`	`284`	`ssa_definition_points_to(var.getDefinition(), context, value, origin)`
`285`	`285`	`or`
`286`	`286`	`exists(EssaVariable prev \|`
`287`		`- ssaShortCut(prev, var) and`
	`287`	`+ ssaShortCut+(prev, var) and`
`288`	`288`	`variablePointsTo(prev, context, value, origin)`
`289`	`289`	`)`
`290`	`290`	`}`
`@@ -305,10 +305,6 @@ cached module PointsToInternal {`
`305`	`305`	`start = def.getInput() and`
`306`	`306`	`end.getDefinition() = def`
`307`	`307`	`)`
`308`		`- or`
`309`		`- exists(EssaVariable mid \|`
`310`		`- ssaShortCut(start, mid) and ssaShortCut(mid, end)`
`311`		`- )`
`312`	`308`	`}`
`313`	`309`
`314`	`310`	`pragma [noinline]`