JS: Mark a missing alert

asgerf · asgerf · commit 834e3a2a67a8 · 2025-02-25T17:29:47.000+01:00
diff --git a/javascript/ql/test/query-tests/Security/CWE-915/PrototypePollutingAssignment/lib.js b/javascript/ql/test/query-tests/Security/CWE-915/PrototypePollutingAssignment/lib.js
@@ -67,7 +67,7 @@ class Foo {
     const obj = this.obj;
     const path = this.path;
     const value = this.value;
-    return (obj[path[0]][path[1]] = value); // $ Alert
+    return (obj[path[0]][path[1]] = value); // $ MISSING: Alert - lacking local field step
   }
 
   safe() {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ class Foo {`
`67`	`67`	`const obj = this.obj;`
`68`	`68`	`const path = this.path;`
`69`	`69`	`const value = this.value;`
`70`		`- return (obj[path[0]][path[1]] = value); // $ Alert`
	`70`	`+ return (obj[path[0]][path[1]] = value); // $ MISSING: Alert - lacking local field step`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`safe() {`