Java: support Argument[this] in NotAModelApiParameter

Stephan Brandauer · Stephan Brandauer · commit 82fd0e45aa3e · 2023-07-28T14:04:53.000+02:00
diff --git a/java/ql/src/Telemetry/AutomodelFrameworkModeCharacteristics.qll b/java/ql/src/Telemetry/AutomodelFrameworkModeCharacteristics.qll
@@ -262,7 +262,7 @@ private class NotAModelApiParameter extends CharacteristicsImpl::UninterestingTo
   NotAModelApiParameter() { this = "not a model API parameter" }
 
   override predicate appliesToEndpoint(Endpoint e) {
-    not exists(ModelExclusions::ModelApi api | api.getAParameter() = e.asTop())
+    not exists(ModelExclusions::ModelApi api | api = e.getEnclosingCallable())
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ private class NotAModelApiParameter extends CharacteristicsImpl::UninterestingTo`
`262`	`262`	`NotAModelApiParameter() { this = "not a model API parameter" }`
`263`	`263`
`264`	`264`	`override predicate appliesToEndpoint(Endpoint e) {`
`265`		`- not exists(ModelExclusions::ModelApi api \| api.getAParameter() = e.asTop())`
	`265`	`+ not exists(ModelExclusions::ModelApi api \| api = e.getEnclosingCallable())`
`266`	`266`	`}`
`267`	`267`	`}`
`268`	`268`