Merge pull request #2655 from Semmle/jbj-patch-1

geoffw0 · web-flow · commit 80997a332364 · 2020-01-21T09:44:41.000Z
C++: Fix typo in MallocSizeExpr
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/NtohlArrayNoBound.qll b/cpp/ql/src/Likely Bugs/Memory Management/NtohlArrayNoBound.qll
@@ -122,7 +122,7 @@ class MallocSizeExpr extends BufferAccess, FunctionCall {
 
   override Expr getPointer() { none() }
 
-  override Expr getAccessedLength() { result = getArgument(1) }
+  override Expr getAccessedLength() { result = getArgument(0) }
 }
 
 class NetworkFunctionCall extends FunctionCall {

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ class MallocSizeExpr extends BufferAccess, FunctionCall {`
`122`	`122`
`123`	`123`	`override Expr getPointer() { none() }`
`124`	`124`
`125`		`- override Expr getAccessedLength() { result = getArgument(1) }`
	`125`	`+ override Expr getAccessedLength() { result = getArgument(0) }`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`class NetworkFunctionCall extends FunctionCall {`