Remove addressed FIXME

smowton · smowton · commit 7ffe863ba621 · 2023-04-12T14:19:06.000+01:00
This was addressed by adding `getAPackageWithSummarizedCallables`
diff --git a/go/ql/lib/semmle/go/security/ExternalAPIs.qll b/go/ql/lib/semmle/go/security/ExternalAPIs.qll
@@ -181,7 +181,6 @@ class UnknownExternalApiDataNode extends ExternalApiDataNode {
     // Not a sink for a commonly-used query
     not isACommonSink(this) and
     // Not in a package that has some functions modeled
-    // FIXME
     not call.getTarget().getPackage() = getAPackageWithModels()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,6 @@ class UnknownExternalApiDataNode extends ExternalApiDataNode {`
`181`	`181`	`// Not a sink for a commonly-used query`
`182`	`182`	`not isACommonSink(this) and`
`183`	`183`	`// Not in a package that has some functions modeled`
`184`		`- // FIXME`
`185`	`184`	`not call.getTarget().getPackage() = getAPackageWithModels()`
`186`	`185`	`}`
`187`	`186`	`}`