wip

Author: hvitved

rust/ql/lib/codeql/rust/elements/internal/CallImpl.qll

@@ -82,14 +82,14 @@ module Impl {
   }
 
   private predicate callHasTraitQualifier(CallExpr call, Trait qualifier) {
-    exists(Path qualifierPath |
+    exists(RelevantPath qualifierPath |
       callHasQualifier(call, _, qualifierPath) and
       qualifier = resolvePath(qualifierPath) and
       // When the qualifier is `Self` and resolves to a trait, it's inside a
       // trait method's default implementation. This is not a dispatch whose
       // target is inferred from the type of the receiver, but should always
       // resolve to the function in the trait block as path resolution does.
-      not qualifierPath.(RelevantPath).isUnqualified("Self")
+      not qualifierPath.isUnqualified("Self")
     )
   }
 

rust/ql/lib/codeql/rust/internal/TypeInference.qll

@@ -1547,12 +1547,19 @@ private predicate assocFuncResolutionDependsOnArgument(Function f, Impl impl, in
 private class FunctionCallExpr extends CallImpl::CallExprCall {
   ItemNode getResolvedFunction() { result = CallExprImpl::getResolvedFunction(this) }
 
+  /**
+   * Holds if the target of this call is ambigous, and type information is required
+   * to disambiguate.
+   */
   predicate isAmbigous() {
     this.hasTrait()
     or
     assocFuncResolutionDependsOnArgument(this.getResolvedFunction(), _, _)
   }
 
+  /**
+   * Gets a target candidate of this ambigous call.
+   */
   pragma[nomagic]
   Function getAnAmbigousCandidate(ImplItemNode impl, int pos, Function f) {
     exists(TraitItemNode trait |