Update cpp/ql/src/experimental/Security/CWE/CWE-193/InvalidPointerDeref.ql

MathiasVP · jketema · web-flow · commit 7f7930b3bb66 · 2023-07-25T10:36:12.000+02:00
Co-authored-by: Jeroen Ketema &lt;93738568+jketema@users.noreply.github.com&gt;
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-193/InvalidPointerDeref.ql b/cpp/ql/src/experimental/Security/CWE/CWE-193/InvalidPointerDeref.ql
@@ -29,7 +29,7 @@
  * In order to do this, we split the problem into three subtasks:
  * 1. First, we find flow from `new int[size]` to `base + size`.
  * 2. Then, we find flow from `base + size` to `end` (on line 3).
- * 3. Finally, we use range-analysis to find a write to (or read from) a pointer that may be equal to `end`.
+ * 3. Finally, we use range-analysis to find a write to (or read from) a pointer that may be greater than or equal to `end`.
  *
  * Step 1 is implemented in `AllocationToInvalidPointer.qll`, and step 2 is implemented by
  * `InvalidPointerToDereference.qll`. See those files for the description of these.

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`* In order to do this, we split the problem into three subtasks:`
`30`	`30`	* 1. First, we find flow from `new int[size]` to `base + size`.
`31`	`31`	* 2. Then, we find flow from `base + size` to `end` (on line 3).
`32`		- * 3. Finally, we use range-analysis to find a write to (or read from) a pointer that may be equal to `end`.
	`32`	+ * 3. Finally, we use range-analysis to find a write to (or read from) a pointer that may be greater than or equal to `end`.
`33`	`33`	`*`
`34`	`34`	* Step 1 is implemented in `AllocationToInvalidPointer.qll`, and step 2 is implemented by
`35`	`35`	* `InvalidPointerToDereference.qll`. See those files for the description of these.