Rename and document viableArgParamSpecific to make clear it is a temporary hook.

Author: smowton

cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll

@@ -83,7 +83,9 @@ predicate parameterMatch(ParameterPosition ppos, ArgumentPosition apos) { ppos =
 /**
  * Holds if flow from `call`'s argument `arg` to parameter `p` is permissible.
  *
- * This is a filter on top of the language-neutral argument/parameter matching implemented by `viableParamArg`.
+ * This is a temporary hook to support technical debt in the Go language; do not use.
  */
 pragma[inline]
-predicate viableParamArgSpecific(DataFlowCall call, ParameterNode p, ArgumentNode arg) { any() }
+predicate golangSpecificParamArgFilter(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
+  any()
+}

cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplCommon.qll

@@ -426,7 +426,7 @@ private module Cached {
       viableParam(call, ppos, p) and
       argumentPositionMatch(call, arg, ppos) and
       compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p)) and
-      viableParamArgSpecific(call, p, arg)
+      golangSpecificParamArgFilter(call, p, arg)
     )
   }
 

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowDispatch.qll

@@ -275,7 +275,9 @@ predicate parameterMatch(ParameterPosition ppos, ArgumentPosition apos) { ppos =
 /**
  * Holds if flow from `call`'s argument `arg` to parameter `p` is permissible.
  *
- * This is a filter on top of the language-neutral argument/parameter matching implemented by `viableParamArg`.
+ * This is a temporary hook to support technical debt in the Go language; do not use.
  */
 pragma[inline]
-predicate viableParamArgSpecific(DataFlowCall call, ParameterNode p, ArgumentNode arg) { any() }
+predicate golangSpecificParamArgFilter(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
+  any()
+}

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImplCommon.qll

@@ -426,7 +426,7 @@ private module Cached {
       viableParam(call, ppos, p) and
       argumentPositionMatch(call, arg, ppos) and
       compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p)) and
-      viableParamArgSpecific(call, p, arg)
+      golangSpecificParamArgFilter(call, p, arg)
     )
   }
 

csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowDispatch.qll

@@ -559,7 +559,9 @@ predicate parameterMatch(ParameterPosition ppos, ArgumentPosition apos) {
 /**
  * Holds if flow from `call`'s argument `arg` to parameter `p` is permissible.
  *
- * This is a filter on top of the language-neutral argument/parameter matching implemented by `viableParamArg`.
+ * This is a temporary hook to support technical debt in the Go language; do not use.
  */
 pragma[inline]
-predicate viableParamArgSpecific(DataFlowCall call, ParameterNode p, ArgumentNode arg) { any() }
+predicate golangSpecificParamArgFilter(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
+  any()
+}

csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImplCommon.qll

@@ -426,7 +426,7 @@ private module Cached {
       viableParam(call, ppos, p) and
       argumentPositionMatch(call, arg, ppos) and
       compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p)) and
-      viableParamArgSpecific(call, p, arg)
+      golangSpecificParamArgFilter(call, p, arg)
     )
   }
 

go/ql/lib/semmle/go/dataflow/internal/DataFlowDispatch.qll

@@ -143,7 +143,7 @@ private predicate isInterfaceMethod(Method c) {
  * a receiver parameter to a concrete method.
  */
 pragma[inline]
-predicate viableParamArgSpecific(
+predicate golangSpecificParamArgFilter(
   DataFlowCall call, DataFlow::ParameterNode p, DataFlow::ArgumentNode arg
 ) {
   // Interface methods calls may be passed strictly to that exact method's model receiver:

go/ql/lib/semmle/go/dataflow/internal/DataFlowImplCommon.qll

@@ -426,7 +426,7 @@ private module Cached {
       viableParam(call, ppos, p) and
       argumentPositionMatch(call, arg, ppos) and
       compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p)) and
-      viableParamArgSpecific(call, p, arg)
+      golangSpecificParamArgFilter(call, p, arg)
     )
   }
 

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll

@@ -175,10 +175,12 @@ private module DispatchImpl {
   /**
    * Holds if flow from `call`'s argument `arg` to parameter `p` is permissible.
    *
-   * This is a filter on top of the language-neutral argument/parameter matching implemented by `viableParamArg`.
+   * This is a temporary hook to support technical debt in the Go language; do not use.
    */
   pragma[inline]
-  predicate viableParamArgSpecific(DataFlowCall call, ParameterNode p, ArgumentNode arg) { any() }
+  predicate golangSpecificParamArgFilter(DataFlowCall call, ParameterNode p, ArgumentNode arg) {
+    any()
+  }
 }
 
 import DispatchImpl

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplCommon.qll

@@ -426,7 +426,7 @@ private module Cached {
       viableParam(call, ppos, p) and
       argumentPositionMatch(call, arg, ppos) and
       compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p)) and
-      viableParamArgSpecific(call, p, arg)
+      golangSpecificParamArgFilter(call, p, arg)
     )
   }