Merge pull request #3045 from Semmle/esbena-patch-2

esbena · web-flow · commit 7dc80664e6b9 · 2020-03-16T22:28:22.000+01:00
JS: loosen qldoc for `barrierGuardIsRelevant`
diff --git a/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll b/javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
@@ -354,7 +354,7 @@ private predicate barrierGuardBlocksExpr(
 }
 
 /**
- * Holds if `guard` blocks the flow of a value reachable through exploratory flow.
+ * Holds if `guard` may block the flow of a value reachable through exploratory flow.
  */
 pragma[noinline]
 private predicate barrierGuardIsRelevant(BarrierGuardNode guard) {

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ private predicate barrierGuardBlocksExpr(`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`/**`
`357`		- * Holds if `guard` blocks the flow of a value reachable through exploratory flow.
	`357`	+ * Holds if `guard` may block the flow of a value reachable through exploratory flow.
`358`	`358`	`*/`
`359`	`359`	`pragma[noinline]`
`360`	`360`	`private predicate barrierGuardIsRelevant(BarrierGuardNode guard) {`