WIP

Author: paldepind

rust/ql/lib/codeql/rust/internal/TypeInference.qll

@@ -1802,6 +1802,10 @@ private module BlanketImplementation {
   }
 
   predicate methodCallMatchesBlanketImpl(MethodCall mc, Type t, Impl impl, Trait trait, Function f) {
+    // Only check method calls where we have ruled out inherent method targets.
+    // Ideally we would also check if non-blanket method targets have been ruled
+    // out.
+    methodCallHasNoInherentTarget(mc) and
     exists(string name, int arity |
       isMethodCall(mc, t, name, arity) and
       blanketImplementationMethod(impl, trait, name, arity, f)
@@ -1871,8 +1875,8 @@ private Function resolveMethodCallTarget(MethodCall mc) {
   // The method comes from an `impl` block targeting the type of the receiver.
   result = getMethodFromImpl(mc)
   or
-  // result = BlanketImplementation::getMethodFromBlanketImpl(mc)
-  // or
+  result = BlanketImplementation::getMethodFromBlanketImpl(mc)
+  or
   // The type of the receiver is a type parameter and the method comes from a
   // trait bound on the type parameter.
   result = getTypeParameterMethod(mc.getTypeAt(TypePath::nil()), mc.getMethodName())