Ruby: Add more callback flow tests

Author: hvitved

ruby/ql/test/library-tests/dataflow/global/Flow.expected

@@ -1,6 +1,24 @@
 testFailures
+| callbacks.rb:18:25:18:25 | x | Unexpected result: hasValueFlow=1 |
+| callbacks.rb:29:37:29:37 | x | Unexpected result: hasValueFlow=2 |
 edges
 | blocks.rb:14:12:14:20 | call to source | blocks.rb:8:10:8:14 | yield ... |
+| callbacks.rb:9:15:9:15 | x | callbacks.rb:10:12:10:12 | x |
+| callbacks.rb:10:12:10:12 | x | callbacks.rb:17:15:17:15 | x |
+| callbacks.rb:10:12:10:12 | x | callbacks.rb:18:15:18:15 | x |
+| callbacks.rb:13:20:13:20 | x | callbacks.rb:14:14:14:14 | x |
+| callbacks.rb:14:14:14:14 | x | callbacks.rb:9:15:9:15 | x |
+| callbacks.rb:17:15:17:15 | x | callbacks.rb:17:25:17:25 | x |
+| callbacks.rb:17:31:17:38 | call to taint | callbacks.rb:13:20:13:20 | x |
+| callbacks.rb:18:15:18:15 | x | callbacks.rb:18:25:18:25 | x |
+| callbacks.rb:20:17:20:17 | x | callbacks.rb:21:11:21:11 | x |
+| callbacks.rb:21:11:21:11 | x | callbacks.rb:28:31:28:31 | x |
+| callbacks.rb:21:11:21:11 | x | callbacks.rb:29:29:29:29 | x |
+| callbacks.rb:24:23:24:23 | x | callbacks.rb:25:17:25:17 | x |
+| callbacks.rb:25:17:25:17 | x | callbacks.rb:20:17:20:17 | x |
+| callbacks.rb:28:18:28:25 | call to taint | callbacks.rb:24:23:24:23 | x |
+| callbacks.rb:28:31:28:31 | x | callbacks.rb:28:39:28:39 | x |
+| callbacks.rb:29:29:29:29 | x | callbacks.rb:29:37:29:37 | x |
 | captured_variables.rb:9:24:9:24 | x | captured_variables.rb:10:10:10:23 | -> { ... } [captured x] |
 | captured_variables.rb:9:24:9:24 | x | captured_variables.rb:11:5:11:6 | fn [captured x] |
 | captured_variables.rb:10:5:10:6 | fn [captured x] | captured_variables.rb:11:5:11:6 | fn [captured x] |
@@ -256,6 +274,24 @@ edges
 nodes
 | blocks.rb:8:10:8:14 | yield ... | semmle.label | yield ... |
 | blocks.rb:14:12:14:20 | call to source | semmle.label | call to source |
+| callbacks.rb:9:15:9:15 | x | semmle.label | x |
+| callbacks.rb:10:12:10:12 | x | semmle.label | x |
+| callbacks.rb:13:20:13:20 | x | semmle.label | x |
+| callbacks.rb:14:14:14:14 | x | semmle.label | x |
+| callbacks.rb:17:15:17:15 | x | semmle.label | x |
+| callbacks.rb:17:25:17:25 | x | semmle.label | x |
+| callbacks.rb:17:31:17:38 | call to taint | semmle.label | call to taint |
+| callbacks.rb:18:15:18:15 | x | semmle.label | x |
+| callbacks.rb:18:25:18:25 | x | semmle.label | x |
+| callbacks.rb:20:17:20:17 | x | semmle.label | x |
+| callbacks.rb:21:11:21:11 | x | semmle.label | x |
+| callbacks.rb:24:23:24:23 | x | semmle.label | x |
+| callbacks.rb:25:17:25:17 | x | semmle.label | x |
+| callbacks.rb:28:18:28:25 | call to taint | semmle.label | call to taint |
+| callbacks.rb:28:31:28:31 | x | semmle.label | x |
+| callbacks.rb:28:39:28:39 | x | semmle.label | x |
+| callbacks.rb:29:29:29:29 | x | semmle.label | x |
+| callbacks.rb:29:37:29:37 | x | semmle.label | x |
 | captured_variables.rb:9:24:9:24 | x | semmle.label | x |
 | captured_variables.rb:10:5:10:6 | fn [captured x] | semmle.label | fn [captured x] |
 | captured_variables.rb:10:10:10:23 | -> { ... } [captured x] | semmle.label | -> { ... } [captured x] |
@@ -552,6 +588,10 @@ subpaths
 | instance_variables.rb:120:6:120:10 | foo16 [@field] | instance_variables.rb:13:5:15:7 | self in get_field [@field] | instance_variables.rb:14:9:14:21 | return | instance_variables.rb:120:6:120:20 | call to get_field |
 #select
 | blocks.rb:8:10:8:14 | yield ... | blocks.rb:14:12:14:20 | call to source | blocks.rb:8:10:8:14 | yield ... | $@ | blocks.rb:14:12:14:20 | call to source | call to source |
+| callbacks.rb:17:25:17:25 | x | callbacks.rb:17:31:17:38 | call to taint | callbacks.rb:17:25:17:25 | x | $@ | callbacks.rb:17:31:17:38 | call to taint | call to taint |
+| callbacks.rb:18:25:18:25 | x | callbacks.rb:17:31:17:38 | call to taint | callbacks.rb:18:25:18:25 | x | $@ | callbacks.rb:17:31:17:38 | call to taint | call to taint |
+| callbacks.rb:28:39:28:39 | x | callbacks.rb:28:18:28:25 | call to taint | callbacks.rb:28:39:28:39 | x | $@ | callbacks.rb:28:18:28:25 | call to taint | call to taint |
+| callbacks.rb:29:37:29:37 | x | callbacks.rb:28:18:28:25 | call to taint | callbacks.rb:29:37:29:37 | x | $@ | callbacks.rb:28:18:28:25 | call to taint | call to taint |
 | captured_variables.rb:10:20:10:20 | x | captured_variables.rb:13:20:13:29 | call to taint | captured_variables.rb:10:20:10:20 | x | $@ | captured_variables.rb:13:20:13:29 | call to taint | call to taint |
 | captured_variables.rb:17:14:17:14 | x | captured_variables.rb:20:25:20:34 | call to taint | captured_variables.rb:17:14:17:14 | x | $@ | captured_variables.rb:20:25:20:34 | call to taint | call to taint |
 | captured_variables.rb:24:14:24:14 | x | captured_variables.rb:27:48:27:57 | call to taint | captured_variables.rb:24:14:24:14 | x | $@ | captured_variables.rb:27:48:27:57 | call to taint | call to taint |

ruby/ql/test/library-tests/dataflow/global/TypeTrackingInlineTest.expected

@@ -1,4 +1,6 @@
 testFailures
+| callbacks.rb:17:41:17:58 | # $ hasValueFlow=1 | Missing result:hasValueFlow=1 |
+| callbacks.rb:29:37:29:37 | x | Unexpected result: hasValueFlow=2 |
 | captured_variables.rb:50:10:50:10 | x | Fixed missing result:hasValueFlow=2 |
 | captured_variables.rb:68:25:68:68 | # $ hasValueFlow=3 $ MISSING: hasValueFlow=4 | Missing result:hasValueFlow=3 |
 | captured_variables.rb:72:21:72:66 | # $ hasValueFlow=4 $ SPURIOUS: hasValueFlow=3  | Fixed spurious result:hasValueFlow=3 |

ruby/ql/test/library-tests/dataflow/global/callbacks.rb

@@ -0,0 +1,29 @@
+def taint x
+    x
+end
+
+def sink x
+    puts "SINK: #{x}"
+end
+
+def apply (f, x)
+    f.call(x)
+end
+
+def apply_wrap (f, x)
+    apply(f, x)
+end
+
+apply_wrap(->(x) { sink(x) }, taint(1)) # $ hasValueFlow=1
+apply_wrap(->(x) { sink(x) }, "safe")
+
+def apply_block x
+    yield x
+end
+
+def apply_block_wrap (x, &block)
+    apply_block(x, &block)
+end
+
+apply_block_wrap(taint(2)) { |x| sink(x) } # $ hasValueFlow=2
+apply_block_wrap("safe") { |x| sink(x) }