|
1 | 1 | /** |
2 | | - * Provides classes and predicates for deserialization vulnerabilities. |
| 2 | + * Provides classes and predicates for finding deserialization vulnerabilities. |
3 | 3 | */ |
4 | 4 |
|
5 | 5 | import semmle.code.java.dataflow.FlowSources |
@@ -123,7 +123,7 @@ private class SafeKryo extends DataFlow2::Configuration { |
123 | 123 | } |
124 | 124 |
|
125 | 125 | /** |
126 | | - * Holds if `ma` is a call that triggers deserialization with tainted data from `sink`. |
| 126 | + * Holds if `ma` is a call that deserializes data from `sink`. |
127 | 127 | */ |
128 | 128 | predicate unsafeDeserialization(MethodAccess ma, Expr sink) { |
129 | 129 | exists(Method m | m = ma.getMethod() | |
@@ -191,7 +191,7 @@ predicate unsafeDeserialization(MethodAccess ma, Expr sink) { |
191 | 191 | class UnsafeDeserializationSink extends DataFlow::ExprNode { |
192 | 192 | UnsafeDeserializationSink() { unsafeDeserialization(_, this.getExpr()) } |
193 | 193 |
|
194 | | - /** Returns a call that triggers unsafe deserialization. */ |
| 194 | + /** Gets a call that triggers unsafe deserialization. */ |
195 | 195 | MethodAccess getMethodAccess() { unsafeDeserialization(result, this.getExpr()) } |
196 | 196 | } |
197 | 197 |
|
@@ -286,7 +286,7 @@ class EnableJacksonDefaultTypingConfig extends DataFlow2::Configuration { |
286 | 286 | } |
287 | 287 |
|
288 | 288 | /** |
289 | | - * Tracks flow from calls which set a type validator to a subsequent Jackson deserialization method call, |
| 289 | + * Tracks flow from calls that set a type validator to a subsequent Jackson deserialization method call, |
290 | 290 | * including across builder method calls. |
291 | 291 | * |
292 | 292 | * Such a Jackson deserialization method call is safe because validation will likely prevent instantiating unexpected types. |
|
0 commit comments