Adress review suggestions - cleanups

Author: joefarebrother

python/ql/src/Classes/CallsToInitDel/MethodCallOrder.qll

@@ -21,7 +21,6 @@ predicate multipleCallsToSuperclassMethod(
 }
 
 /** Holds if l1 comes before l2, assuming they're in the same file. */
-pragma[inline]
 private predicate locationBefore(Location l1, Location l2) {
   l1.getStartLine() < l2.getStartLine()
   or
@@ -45,7 +44,6 @@ Function getDirectSuperCallTargetFromCall(
   Class mroBase, Function meth, DataFlow::MethodCallNode call, string name
 ) {
   meth = call.getScope() and
-  getADirectSuperclass*(mroBase) = meth.getScope() and
   meth.getName() = name and
   call.calls(_, name) and
   mroBase = getADirectSubclass*(meth.getScope()) and
@@ -56,7 +54,7 @@ Function getDirectSuperCallTargetFromCall(
     result = findFunctionAccordingToMroKnownStartingClass(targetCls, mroBase, name)
     or
     // targetCls is the mro base for this lookup.
-    // note however that if the call we find uses super(), that still uses the mro of the instance `self` will sill be used
+    // note however that if the call we find uses super(), that still uses the mro of the instance `self`
     // assuming it's 0-arg or is 2-arg with `self` as second arg.
     callsMethodOnClassWithSelf(meth, call, targetCls, _) and
     result = findFunctionAccordingToMroKnownStartingClass(targetCls, targetCls, name)
@@ -96,7 +94,7 @@ predicate superCall(DataFlow::MethodCallNode call, string name) {
   )
 }
 
-/** Holds if `meth` calls `super().<name>` where `name` is the name of the method. */
+/** Holds if `meth` calls a `super()` method of the same name. */
 predicate callsSuper(Function meth) {
   exists(DataFlow::MethodCallNode call |
     call.getScope() = meth and
@@ -122,7 +120,7 @@ predicate callsMethodOnUnknownClassWithSelf(Function meth, string name) {
     call.calls(callTarget, name) and
     self.getParameter() = meth.getArg(0) and
     self.(DataFlow::LocalSourceNode).flowsTo(call.getArg(0)) and
-    not exists(Class target | callTarget = classTracker(target))
+    not callTarget = classTracker(any(Class target))
   )
 }