Set mustWrite to false in response to PR feedback

MathiasVP · jbj · web-flow · commit 7502c6f82172 · 2020-05-15T14:32:46.000+02:00
Co-authored-by: Jonas Jensen &lt;jbj@github.com&gt;
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/GetDelim.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/GetDelim.qll
@@ -26,7 +26,7 @@ class GetDelimFunction extends TaintFunction, AliasFunction, SideEffectFunction,
   override predicate hasSpecificWriteSideEffect(ParameterIndex i, boolean buffer, boolean mustWrite) {
     i = [0, 1] and
     buffer = false and
-    mustWrite = true
+    mustWrite = false
   }
 
   override predicate hasSpecificReadSideEffect(ParameterIndex i, boolean buffer) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class GetDelimFunction extends TaintFunction, AliasFunction, SideEffectFunction,`
`26`	`26`	`override predicate hasSpecificWriteSideEffect(ParameterIndex i, boolean buffer, boolean mustWrite) {`
`27`	`27`	`i = [0, 1] and`
`28`	`28`	`buffer = false and`
`29`		`- mustWrite = true`
	`29`	`+ mustWrite = false`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`override predicate hasSpecificReadSideEffect(ParameterIndex i, boolean buffer) {`