Java: Allow empty package name in model definitions.

michaelnebel · michaelnebel · commit 74f02cf85516 · 2022-11-28T12:30:35.000+01:00
diff --git a/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll b/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
@@ -549,7 +549,7 @@ module ModelValidation {
       ext = "" and
       pred = "negative summary"
     |
-      not package.regexpMatch("[a-zA-Z0-9_\\.]+") and
+      not package.regexpMatch("[a-zA-Z0-9_\\.]*") and
       result = "Dubious package \"" + package + "\" in " + pred + " model."
       or
       not type.regexpMatch("[a-zA-Z0-9_\\$<>]+") and

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ module ModelValidation {`
`549`	`549`	`ext = "" and`
`550`	`550`	`pred = "negative summary"`
`551`	`551`	`\|`
`552`		`- not package.regexpMatch("[a-zA-Z0-9_\\.]+") and`
	`552`	`+ not package.regexpMatch("[a-zA-Z0-9_\\.]*") and`
`553`	`553`	`result = "Dubious package \"" + package + "\" in " + pred + " model."`
`554`	`554`	`or`
`555`	`555`	`not type.regexpMatch("[a-zA-Z0-9_\\$<>]+") and`