Adding intermediate solution towards deprecating ThrowingFunction

bdrodes · bdrodes · commit 7059fc3e31bc · 2024-11-21T12:10:42.000-05:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCall.qll
@@ -364,10 +364,14 @@ class TranslatedFunctionCall extends TranslatedCallExpr, TranslatedDirectCall {
 
   final override predicate mayThrowException() {
     expr.getTarget().(ThrowingFunction).mayThrowException(_)
+    or
+    expr.getTarget() instanceof AlwaysSehThrowingFunction
   }
 
   final override predicate mustThrowException() {
     expr.getTarget().(ThrowingFunction).mayThrowException(true)
+    or
+    expr.getTarget() instanceof AlwaysSehThrowingFunction
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -364,10 +364,14 @@ class TranslatedFunctionCall extends TranslatedCallExpr, TranslatedDirectCall {`
`364`	`364`
`365`	`365`	`final override predicate mayThrowException() {`
`366`	`366`	`expr.getTarget().(ThrowingFunction).mayThrowException(_)`
	`367`	`+ or`
	`368`	`+ expr.getTarget() instanceof AlwaysSehThrowingFunction`
`367`	`369`	`}`
`368`	`370`
`369`	`371`	`final override predicate mustThrowException() {`
`370`	`372`	`expr.getTarget().(ThrowingFunction).mayThrowException(true)`
	`373`	`+ or`
	`374`	`+ expr.getTarget() instanceof AlwaysSehThrowingFunction`
`371`	`375`	`}`
`372`	`376`	`}`
`373`	`377`