Merge pull request #13091 from atorralba/atorralba/java/inputstreamwrapper-transitive

Java: Make inputStreamWrapper consider supertypes transitively

Author: atorralba

java/ql/lib/change-notes/2023-05-22-inputstreamwrapper-transitive.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Dataflow analysis has a new flow step through constructors of transitive subtypes of `java.io.InputStream` that wrap an underlying data source. Previously, the step only existed for direct subtypes of `java.io.InputStream`.

java/ql/lib/semmle/code/java/dataflow/internal/TaintTrackingUtil.qll

@@ -255,8 +255,9 @@ private class BulkData extends RefType {
  * status of its argument.
  */
 private predicate inputStreamWrapper(Constructor c, int argi) {
+  not c.fromSource() and
   c.getParameterType(argi) instanceof BulkData and
-  c.getDeclaringType().getASourceSupertype().hasQualifiedName("java.io", "InputStream")
+  c.getDeclaringType().getASourceSupertype+().hasQualifiedName("java.io", "InputStream")
 }
 
 /** An object construction that preserves the data flow status of any of its arguments. */