C#: Address review comments.

Author: calumgrant

csharp/ql/src/Concurrency/Concurrency.qll

@@ -15,16 +15,16 @@ private class WaitCall extends MethodCall {
 class WaitStmt extends ExprStmt {
   WaitStmt() { getExpr() instanceof WaitCall }
 
-  /** Gets the expression this wait call is waiting on. */
+  /** Gets the expression that this wait call is waiting on. */
   Expr getLock() { result = getExpr().(WaitCall).getExpr() }
 
-  /** Gets the variable this wait call is waiting on, if any. */
+  /** Gets the variable that this wait call is waiting on, if any. */
   Variable getWaitVariable() { result.getAnAccess() = getLock() }
 
   /** Holds if this wait call waits on `this`. */
   predicate isWaitThis() { getLock() instanceof ThisAccess }
 
-  /** Gets the type this wait call waits on, if any. */
+  /** Gets the type that this wait call waits on, if any. */
   Type getWaitTypeObject() { result = getLock().(TypeofExpr).getTypeAccess().getTarget() }
 }
 
@@ -44,7 +44,7 @@ private class SynchronizedMethodAttribute extends Attribute {
 private class SynchronizedMethod extends Method {
   SynchronizedMethod() { getAnAttribute() instanceof SynchronizedMethodAttribute }
 
-  /** Holds if the method locks `this`. */
+  /** Holds if this method locks `this`. */
   predicate isLockThis() { not isStatic() }
 
   /** Gets the type that is locked by this method, if any. */

csharp/ql/src/Documentation/Documentation.qll

@@ -61,13 +61,13 @@ predicate isDocumentationNeeded(Modifiable decl) {
 class ReturnsXmlComment extends XmlComment {
   ReturnsXmlComment() { getOpenTag(_) = "returns" }
 
-  /** Holds if the element has a body at offset `offset`. */
+  /** Holds if the element in this comment has a body at offset `offset`. */
   predicate hasBody(int offset) { hasBody("returns", offset) }
 
-  /** Holds if the element is an opening tag at offset `offset`. */
+  /** Holds if the element in this comment is an opening tag at offset `offset`. */
   predicate isOpenTag(int offset) { "returns" = getOpenTag(offset) }
 
-  /** Holds if the element is an empty tag at offset `offset`. */
+  /** Holds if the element in this comment is an empty tag at offset `offset`. */
   predicate isEmptyTag(int offset) { "returns" = getEmptyTag(offset) }
 }
 
@@ -78,7 +78,7 @@ class ExceptionXmlComment extends XmlComment {
   /** Gets a `cref` attribute at offset `offset`, if any. */
   string getCref(int offset) { result = getAttribute("exception", "cref", offset) }
 
-  /** Holds if the element has a body at offset `offset`. */
+  /** Holds if the element in this comment has a body at offset `offset`. */
   predicate hasBody(int offset) { hasBody("exception", offset) }
 }
 
@@ -89,7 +89,7 @@ class ParamXmlComment extends XmlComment {
   /** Gets the name of this parameter at offset `offset`. */
   string getName(int offset) { getAttribute("param", "name", offset) = result }
 
-  /** Holds if the element has a body at offset `offset`. */
+  /** Holds if the element in this comment has a body at offset `offset`. */
   predicate hasBody(int offset) { hasBody("param", offset) }
 }
 
@@ -100,21 +100,21 @@ class TypeparamXmlComment extends XmlComment {
   /** Gets the `name` attribute of this element at offset `offset`. */
   string getName(int offset) { getAttribute("typeparam", "name", offset) = result }
 
-  /** Holds if the element has a body at offset `offset`. */
+  /** Holds if the element in this comment has a body at offset `offset`. */
   predicate hasBody(int offset) { hasBody("typeparam", offset) }
 }
 
 /** An XML comment containing a `<summary>` tag. */
 class SummaryXmlComment extends XmlComment {
   SummaryXmlComment() { getOpenTag(_) = "summary" }
 
-  /** Holds if the element has a body at offset `offset`. */
+  /** Holds if the element in this comment has a body at offset `offset`. */
   predicate hasBody(int offset) { hasBody("summary", offset) }
 
-  /** Holds if the element has an open tag at offset `offset`. */
+  /** Holds if the element in this comment has an open tag at offset `offset`. */
   predicate isOpenTag(int offset) { "summary" = getOpenTag(offset) }
 
-  /** Holds if the element is empty at offset `offset`. */
+  /** Holds if the element in this comment is empty at offset `offset`. */
   predicate isEmptyTag(int offset) { "summary" = getEmptyTag(offset) }
 }
 

csharp/ql/src/semmle/code/cil/Instructions.qll

@@ -1,5 +1,8 @@
 /**
  * Provides classes representing individual opcodes.
+ *
+ * See ECMA-335 (http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-335.pdf)
+ * pages 32-101 for a detailed explanation of these instructions.
  */
 
 private import CIL
@@ -365,7 +368,7 @@ module Opcodes {
     override string getOpcodeName() { result = "bge" }
   }
 
-  /** A `bne.un` instruction. */
+  /** A `bne.un.s` instruction. */
   class Bne_un_s extends BinaryBranch, @cil_bne_un_s {
     override string getOpcodeName() { result = "bne.un.s" }
   }
@@ -407,7 +410,7 @@ module Opcodes {
 
   /** A `bgt.in.s` instruction. */
   class Bgt_in_s extends BinaryBranch, @cil_bgt_un_s {
-    override string getOpcodeName() { result = "bgt.un.s" }
+    override string getOpcodeName() { result = "bgt.in.s" }
   }
 
   /** A `bge.in.s` instruction. */
@@ -466,7 +469,7 @@ module Opcodes {
 
   /** A `clt.un` instruction. */
   class Clt_un extends ComparisonOperation, @cil_clt_un {
-    override string getOpcodeName() { result = "cgt.un" }
+    override string getOpcodeName() { result = "clt.un" }
   }
 
   /** A `clt` instruction. */
@@ -853,7 +856,7 @@ module Opcodes {
     override Type getType() { result = getAccess() }
   }
 
-  /** An `ldelem_ref` instruction. */
+  /** An `ldelem.ref` instruction. */
   class Ldelem_ref extends ReadArrayElement, @cil_ldelem_ref {
     override string getOpcodeName() { result = "ldelem.ref" }
 
@@ -1206,7 +1209,7 @@ module Opcodes {
     override DoubleType getType() { exists(result) }
   }
 
-  /** A `conv.r8.un` instruction. */
+  /** A `conv.r.un` instruction. */
   class Conv_r_un extends Conversion, @cil_conv_r_un {
     override string getOpcodeName() { result = "conv.r.un" }
 
@@ -1327,7 +1330,7 @@ module Opcodes {
 
   /** An `stind.r8` instruction. */
   class Stind_r8 extends StoreIndirect, @cil_stind_r8 {
-    override string getOpcodeName() { result = "stind.r4" }
+    override string getOpcodeName() { result = "stind.r8" }
   }
 
   /** An `stind.ref` instruction. */