JS: address review comments

Esben Sparre Andreasen · Esben Sparre Andreasen · commit 6d6379fc09df · 2018-12-10T22:03:52.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/Concepts.qll b/javascript/ql/src/semmle/javascript/Concepts.qll
@@ -72,7 +72,7 @@ abstract class DatabaseAccess extends DataFlow::Node {
 abstract class PersistentReadAccess extends DataFlow::Node {
 
   /**
-   * Gets the corresponding persistent write, if any.
+   * Gets a corresponding persistent write, if any.
    */
   abstract PersistentWriteAccess getAWrite();
 
diff --git a/javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll b/javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll
@@ -232,6 +232,9 @@ module TaintTracking {
     }
   }
 
+  /**
+   * A taint propagating data flow edge through persistent storage.
+   */
   private class StorageTaintStep extends AdditionalTaintStep {
 
     PersistentReadAccess read;

Original file line number	Diff line number	Diff line change
`@@ -232,6 +232,9 @@ module TaintTracking {`
`232`	`232`	`}`
`233`	`233`	`}`
`234`	`234`
	`235`	`+ /**`
	`236`	`+ * A taint propagating data flow edge through persistent storage.`
	`237`	`+ */`
`235`	`238`	`private class StorageTaintStep extends AdditionalTaintStep {`
`236`	`239`
`237`	`240`	`PersistentReadAccess read;`