Skip to content

Commit 6c76826

Browse files
authored
Merge pull request #716 from xiemaisi/js/cosmetics
Approved by esben-semmle
2 parents 9b8bf96 + 5ccad6f commit 6c76826

File tree

1 file changed

+4
-5
lines changed
  • javascript/ql/src/semmle/javascript/frameworks

1 file changed

+4
-5
lines changed

javascript/ql/src/semmle/javascript/frameworks/Express.qll

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -851,20 +851,19 @@ module Express {
851851
}
852852

853853
/** A call to `response.sendFile`, considered as a file system access. */
854-
private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::ValueNode {
855-
override MethodCallExpr astNode;
856-
854+
private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::MethodCallNode {
857855
ResponseSendFileAsFileSystemAccess() {
858856
exists (string name | name = "sendFile" or name = "sendfile" |
859-
asExpr().(MethodCallExpr).calls(any(ResponseExpr res), name))
857+
calls(any(ResponseExpr res).flow(), name)
858+
)
860859
}
861860

862861
override DataFlow::Node getADataNode() {
863862
none()
864863
}
865864

866865
override DataFlow::Node getAPathArgument() {
867-
result = DataFlow::valueNode(astNode.getArgument(0))
866+
result = getArgument(0)
868867
}
869868

870869
override DataFlow::Node getRootPathArgument() {

0 commit comments

Comments
 (0)