C++: The update of a for-loop is ExprInVoidContext

jbj · jbj · commit 6c069ff44483 · 2019-10-24T15:27:54.000+02:00
diff --git a/cpp/ql/src/semmle/code/cpp/commons/VoidContext.qll b/cpp/ql/src/semmle/code/cpp/commons/VoidContext.qll
@@ -36,6 +36,8 @@ private predicate exprInVoidContext(Expr e) {
     exists(CommaExpr c | c.getLeftOperand() = e)
     or
     exists(CommaExpr c | c.getRightOperand() = e and c instanceof ExprInVoidContext)
+    or
+    exists(ForStmt for | for.getUpdate() = e)
   ) and
   not e.getActualType() instanceof VoidType
 }

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,8 @@ private predicate exprInVoidContext(Expr e) {`
`36`	`36`	`exists(CommaExpr c \| c.getLeftOperand() = e)`
`37`	`37`	`or`
`38`	`38`	`exists(CommaExpr c \| c.getRightOperand() = e and c instanceof ExprInVoidContext)`
	`39`	`+ or`
	`40`	`+ exists(ForStmt for \| for.getUpdate() = e)`
`39`	`41`	`) and`
`40`	`42`	`not e.getActualType() instanceof VoidType`
`41`	`43`	`}`