Java: Automodel extraction fix; previously, we treated endpoints that were marked as sinks, as well as summary-neutrals as 'erroneous'

Stephan Brandauer · Stephan Brandauer · commit 698b8d3c5c18 · 2023-07-25T16:52:27.000+02:00
diff --git a/java/ql/src/Telemetry/AutomodelFrameworkModeCharacteristics.qll b/java/ql/src/Telemetry/AutomodelFrameworkModeCharacteristics.qll
@@ -60,7 +60,7 @@ module FrameworkCandidatesImpl implements SharedCharacteristics::CandidateSig {
   predicate isNeutral(Endpoint e) {
     exists(string package, string type, string name, string signature |
       sinkSpec(e, package, type, name, signature, _, _) and
-      ExternalFlow::neutralModel(package, type, name, [signature, ""], _, _)
+      ExternalFlow::neutralModel(package, type, name, [signature, ""], "sink", _)
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ module FrameworkCandidatesImpl implements SharedCharacteristics::CandidateSig {`
`60`	`60`	`predicate isNeutral(Endpoint e) {`
`61`	`61`	`exists(string package, string type, string name, string signature \|`
`62`	`62`	`sinkSpec(e, package, type, name, signature, _, _) and`
`63`		`- ExternalFlow::neutralModel(package, type, name, [signature, ""], _, _)`
	`63`	`+ ExternalFlow::neutralModel(package, type, name, [signature, ""], "sink", _)`
`64`	`64`	`)`
`65`	`65`	`}`
`66`	`66`