Skip to content

Commit 698957e

Browse files
committed
Python: Correct case of query name and improve help.
1 parent bfc001c commit 698957e

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

change-notes/1.19/analysis-python.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ A new predicate `Stmt.getAnEntryNode()` has been added to make it easier to writ
5757
| **Query** | **Tags** | **Purpose** |
5858
|-----------------------------|-----------|--------------------------------------------------------------------|
5959
| Information exposure through an exception (`py/stack-trace-exposure`) | security, external/cwe/cwe-209, external/cwe/cwe-497 | Finds instances where information about an exception may be leaked to an external user. Enabled on LGTM by default. |
60-
| Request Without Certificate Validation (`py/request-without-cert-validation`) | security, external/cwe/cwe-295 | Finds requests where certificate verification has been explicitly turned off, possibly allowing man-in-the-middle attacks. Not enabled on LGTM by default. |
60+
| Request without certificate validation (`py/request-without-cert-validation`) | security, external/cwe/cwe-295 | Finds requests where certificate verification has been explicitly turned off, possibly allowing man-in-the-middle attacks. Not enabled on LGTM by default. |
6161

6262
## Changes to existing queries
6363

python/ql/src/Security/CWE-295/RequestWithoutValidation.qhelp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
<overview>
77
<p>
88
Encryption is key to the security of most, if not all, online communication.
9-
Using TLS can enusre that neither party in the communication is an interloper.
9+
Using Transport Layer Security (TLS) can ensure that communication cannot be interrupted by an interloper.
1010
For this reason, is is unwise to disable the verification that TLS provides.
11-
<code>requests</code> provides verification by default, and it is only when
11+
Functions in the <code>requests</code> module provide verification by default, and it is only when
1212
explicitly turned off using <code>verify=False</code> that no verification occurs.
1313
</p>
1414
</overview>
@@ -29,10 +29,6 @@ The example shows two unsafe calls to <a href="https://semmle.com">semmle.com</a
2929

3030
<references>
3131
<li>
32-
Common Weakness Enumeration:
33-
<a href="https://cwe.mitre.org/data/definitions/295.html">CWE-295: Improper Certificate Validation</a>.
34-
</li>
35-
<li>
3632
Python requests documentation: <a href="http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification">SSL Cert Verification</a>.
3733
</li>
3834
</references>

python/ql/src/Security/CWE-295/RequestWithoutValidation.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* @name Request Without Certificate Validation
2+
* @name Request without certificate validation
33
* @description Making a request without certificate validation can allow man-in-the-middle attacks.
44
* @kind problem
55
* @problem.severity error

0 commit comments

Comments
 (0)