C++: Add comment from PR feedback

Dave Bartolomeo · Dave Bartolomeo · commit 66381e89ef30 · 2020-04-22T08:11:43.000-04:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll
@@ -1767,6 +1767,11 @@ abstract class TranslatedConditionalExpr extends TranslatedNonConstantExpr {
   override ConditionalExpr expr;
 
   override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {
+    // Note that the ternary flavor needs no explicit `ConditionalBranch` instruction here, because
+    // the condition is a `TranslatedCondition`, which will simply connect the successor edges of
+    // the condition directly to the appropriate then/else block via
+    // `getChild[True|False]Successor()`.
+    // The binary flavor will override this predicate to add the `ConditionalBranch`.
     not resultIsVoid() and
     (
       (

Original file line number	Diff line number	Diff line change
`@@ -1767,6 +1767,11 @@ abstract class TranslatedConditionalExpr extends TranslatedNonConstantExpr {`
`1767`	`1767`	`override ConditionalExpr expr;`
`1768`	`1768`
`1769`	`1769`	`override predicate hasInstruction(Opcode opcode, InstructionTag tag, CppType resultType) {`
	`1770`	+ // Note that the ternary flavor needs no explicit `ConditionalBranch` instruction here, because
	`1771`	+ // the condition is a `TranslatedCondition`, which will simply connect the successor edges of
	`1772`	`+ // the condition directly to the appropriate then/else block via`
	`1773`	+ // `getChild[True\|False]Successor()`.
	`1774`	+ // The binary flavor will override this predicate to add the `ConditionalBranch`.
`1770`	`1775`	`not resultIsVoid() and`
`1771`	`1776`	`(`
`1772`	`1777`	`(`