Merge pull request #532 from geoffw0/query-tags-3

jbj · web-flow · commit 60076cb73499 · 2018-11-30T15:45:01.000+01:00
CPP: Query Tags 3 (JPL_C queries)
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 03/ExitNonterminatingLoop.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 03/ExitNonterminatingLoop.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/exit-nonterminating-loop
  * @problem.severity warning
+ * @tags correctness
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 03/LoopBounds.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 03/LoopBounds.ql
@@ -5,6 +5,8 @@
  * @kind problem
  * @id cpp/jpl-c/loop-bounds
  * @problem.severity warning
+ * @tags correctness
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 04/Recursion.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 04/Recursion.ql
@@ -4,6 +4,10 @@
  * @kind problem
  * @id cpp/jpl-c/recursion
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
+ *       testability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 05/HeapMemory.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 05/HeapMemory.ql
@@ -3,7 +3,9 @@
  * @description Dynamic memory allocation (using malloc() or calloc()) should be confined to the initialization routines of a program.
  * @kind problem
  * @id cpp/jpl-c/heap-memory
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags resources
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 07/ThreadSafety.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 07/ThreadSafety.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/thread-safety
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidNestedSemaphores.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidNestedSemaphores.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/avoid-nested-semaphores
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
+ *       external/jpl
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidSemaphores.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidSemaphores.ql
@@ -3,7 +3,9 @@
  * @description The use of semaphores or locks to access shared data should be avoided.
  * @kind problem
  * @id cpp/jpl-c/avoid-semaphores
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags concurrency
+ *       external/jpl
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/OutOfOrderLocks.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/OutOfOrderLocks.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/out-of-order-locks
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
+ *       external/jpl
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/ReleaseLocksWhenAcquired.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/ReleaseLocksWhenAcquired.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/release-locks-when-acquired
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
+ *       external/jpl
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowGoto.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowGoto.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/simple-control-flow-goto
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowJmp.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowJmp.ql
@@ -4,6 +4,10 @@
  * @kind problem
  * @id cpp/jpl-c/simple-control-flow-jmp
  * @problem.severity warning
+ * @tags correctness
+ *       portability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 12/EnumInitialization.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 12/EnumInitialization.ql
@@ -3,7 +3,10 @@
  * @description In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized. An exception is the pattern to use the last element of an enumerator list to get the number of possible values.
  * @kind problem
  * @id cpp/jpl-c/enum-initialization
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 import cpp
 
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 13/ExternDeclsInHeader.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 13/ExternDeclsInHeader.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/extern-decls-in-header
  * @problem.severity warning
+ * @tags maintainability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFile.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFile.ql
@@ -3,7 +3,11 @@
  * @description Global variables that are not accessed outside their own file should be made static to promote information hiding.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-file
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags maintainability
+ *       modularity
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFunction.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeFunction.ql
@@ -3,7 +3,10 @@
  * @description Global and file-scope variables that are accessed by only one function should be scoped within that function.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-function
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @precision low
+ * @tags maintainability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeLocalHidesGlobal.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 13/LimitedScopeLocalHidesGlobal.ql
@@ -3,7 +3,10 @@
  * @description A local variable or parameter that hides a global variable of the same name.
  * @kind problem
  * @id cpp/jpl-c/limited-scope-local-hides-global
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 import cpp
 
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 14/CheckingReturnValues.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 14/CheckingReturnValues.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/checking-return-values
  * @problem.severity warning
+ * @tags correctness
+ *       reliability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 15/CheckingParameterValues.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 15/CheckingParameterValues.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/checking-parameter-values
  * @problem.severity warning
+ * @tags correctness
+ *       reliability
+ *       external/jpl
  */
 
 import JPL_C.Tasks
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsConstant.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsConstant.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-constant
  * @problem.severity warning
+ * @tags maintainability
+ *       reliability
+ *       external/jpl
  */
 
 import semmle.code.cpp.commons.Assertions
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsDensity.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsDensity.ql
@@ -3,7 +3,10 @@
  * @description All functions of more than 10 lines should have at least one assertion.
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-density
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       reliability
+ *       external/jpl
  */
 
 import semmle.code.cpp.commons.Assertions
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsNonBoolean.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsNonBoolean.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-non-boolean
  * @problem.severity warning
+ * @tags correctness
+ *       external/jpl
  */
 
 import semmle.code.cpp.commons.Assertions
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsSideEffect.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 16/UseOfAssertionsSideEffect.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/use-of-assertions-side-effect
  * @problem.severity warning
+ * @tags correctness
+ *       external/jpl
  */
 
 import semmle.code.cpp.commons.Assertions
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 17/BasicIntTypes.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 17/BasicIntTypes.ql
@@ -3,7 +3,10 @@
  * @description Typedefs that indicate size and signedness should be used in place of the basic types.
  * @kind problem
  * @id cpp/jpl-c/basic-int-types
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 18/CompoundExpressions.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 18/CompoundExpressions.ql
@@ -3,7 +3,10 @@
  * @description In compound expressions with multiple sub-expressions the intended order of evaluation shall be made explicit with parentheses.
  * @kind problem
  * @id cpp/jpl-c/compound-expressions
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-3/Rule 19/NoBooleanSideEffects.ql b/cpp/ql/src/JPL_C/LOC-3/Rule 19/NoBooleanSideEffects.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/no-boolean-side-effects
  * @problem.severity warning
+ * @tags correctness
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUse.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUse.ql
@@ -3,7 +3,10 @@
  * @description The use of the preprocessor must be limited to inclusion of header files and simple macro definitions.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseIfdef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseIfdef.ql
@@ -3,7 +3,10 @@
  * @description The use of conditional compilation directives must be kept to a minimum -- e.g. for header guards only.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-ifdef
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUsePartial.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUsePartial.ql
@@ -3,7 +3,10 @@
  * @description Macros must expand to complete syntactic units -- "#define MY_IF if(" is not legal.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-partial
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseUndisciplined.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 20/PreprocessorUseUndisciplined.ql
@@ -3,7 +3,10 @@
  * @description Macros are not allowed to use complex preprocessor features like variable argument lists and token pasting.
  * @kind problem
  * @id cpp/jpl-c/preprocessor-use-undisciplined
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 21/MacroInBlock.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 21/MacroInBlock.ql
@@ -3,7 +3,10 @@
  * @description Macros shall not be #define'd within a function or a block.
  * @kind problem
  * @id cpp/jpl-c/macro-in-block
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 22/UseOfUndef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 22/UseOfUndef.ql
@@ -3,7 +3,10 @@
  * @description #undef shall not be used.
  * @kind problem
  * @id cpp/jpl-c/use-of-undef
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 23/MismatchedIfdefs.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 23/MismatchedIfdefs.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/mismatched-ifdefs
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleStmtsPerLine.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleStmtsPerLine.ql
@@ -3,7 +3,10 @@
  * @description Putting more than one statement on a single line hinders program understanding.
  * @kind problem
  * @id cpp/jpl-c/multiple-stmts-per-line
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleVarDeclsPerLine.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 24/MultipleVarDeclsPerLine.ql
@@ -3,7 +3,10 @@
  * @description There should be no more than one variable declaration per line.
  * @kind problem
  * @id cpp/jpl-c/multiple-var-decls-per-line
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 25/FunctionSizeLimits.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 25/FunctionSizeLimits.ql
@@ -3,7 +3,10 @@
  * @description Function length should be limited to what can be printed on a single sheet of paper (60 lines). Number of parameters is limited to 6 or fewer.
  * @kind problem
  * @id cpp/jpl-c/function-size-limits
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 26/DeclarationPointerNesting.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 26/DeclarationPointerNesting.ql
@@ -3,7 +3,10 @@
  * @description The declaration of an object should contain no more than two levels of indirection.
  * @kind problem
  * @id cpp/jpl-c/declaration-pointer-nesting
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
+ *       external/jpl
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 27/PointerDereferenceInStmt.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 27/PointerDereferenceInStmt.ql
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerDereferenceMacro.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerDereferenceMacro.ql
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerIndirectionTypedef.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 28/HiddenPointerIndirectionTypedef.ql
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer.ql
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 30/FunctionPointerConversions.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 30/FunctionPointerConversions.ql
diff --git a/cpp/ql/src/JPL_C/LOC-4/Rule 31/IncludesFirst.ql b/cpp/ql/src/JPL_C/LOC-4/Rule 31/IncludesFirst.ql
diff --git a/cpp/ql/src/external/DuplicateBlock.ql b/cpp/ql/src/external/DuplicateBlock.ql
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/NonConstFunctionPointer.expected b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/NonConstFunctionPointer.expected
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/NonConstFunctionPointer.qlref b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/NonConstFunctionPointer.qlref
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/test.c b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 29/NonConstFunctionPointer/test.c
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/FunctionPointerConversions.expected b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/FunctionPointerConversions.expected
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/FunctionPointerConversions.qlref b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/FunctionPointerConversions.qlref
diff --git a/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/test.c b/cpp/ql/test/query-tests/JPL_C/LOC-4/Rule 30/FunctionPointerConversions/test.c
