Temporarily allow TODO- prefix in inline tests

asgerf · asgerf · commit 5ff82b7b8de7 · 2025-02-07T13:55:11.000+01:00
diff --git a/shared/util/codeql/util/test/InlineExpectationsTest.qll b/shared/util/codeql/util/test/InlineExpectationsTest.qll
@@ -347,11 +347,11 @@ module Make<InlineExpectationsTestSig Impl> {
     }
 
     class FalsePositiveTestExpectation extends ValidTestExpectation {
-      FalsePositiveTestExpectation() { this.getKnownFailure() = "SPURIOUS" }
+      FalsePositiveTestExpectation() { this.getKnownFailure() = ["", "TODO-"] + "SPURIOUS" }
     }
 
     class FalseNegativeTestExpectation extends ValidTestExpectation {
-      FalseNegativeTestExpectation() { this.getKnownFailure() = "MISSING" }
+      FalseNegativeTestExpectation() { this.getKnownFailure() = ["", "TODO-"] + "MISSING" }
     }
 
     class InvalidTestExpectation extends Expectation, TInvalidExpectation {
@@ -529,7 +529,7 @@ private string expectationCommentPattern() { result = "\\s*\\$((?:[^/]|/[^/])*)(
  */
 private newtype TColumn =
   TDefaultColumn() or
-  TNamedColumn(string name) { name = ["MISSING", "SPURIOUS"] }
+  TNamedColumn(string name) { name = ["", "TODO-"] + ["MISSING", "SPURIOUS"] }
 
 bindingset[start, content]
 private int getEndOfColumnPosition(int start, string content) {

Original file line number	Diff line number	Diff line change
`@@ -347,11 +347,11 @@ module Make<InlineExpectationsTestSig Impl> {`
`347`	`347`	`}`
`348`	`348`
`349`	`349`	`class FalsePositiveTestExpectation extends ValidTestExpectation {`
`350`		`- FalsePositiveTestExpectation() { this.getKnownFailure() = "SPURIOUS" }`
	`350`	`+ FalsePositiveTestExpectation() { this.getKnownFailure() = ["", "TODO-"] + "SPURIOUS" }`
`351`	`351`	`}`
`352`	`352`
`353`	`353`	`class FalseNegativeTestExpectation extends ValidTestExpectation {`
`354`		`- FalseNegativeTestExpectation() { this.getKnownFailure() = "MISSING" }`
	`354`	`+ FalseNegativeTestExpectation() { this.getKnownFailure() = ["", "TODO-"] + "MISSING" }`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`class InvalidTestExpectation extends Expectation, TInvalidExpectation {`
`@@ -529,7 +529,7 @@ private string expectationCommentPattern() { result = "\\s\\$((?:[^/]\|/[^/]))(`
`529`	`529`	`*/`
`530`	`530`	`private newtype TColumn =`
`531`	`531`	`TDefaultColumn() or`
`532`		`- TNamedColumn(string name) { name = ["MISSING", "SPURIOUS"] }`
	`532`	`+ TNamedColumn(string name) { name = ["", "TODO-"] + ["MISSING", "SPURIOUS"] }`
`533`	`533`
`534`	`534`	`bindingset[start, content]`
`535`	`535`	`private int getEndOfColumnPosition(int start, string content) {`