Merge pull request #15646 from smowton/smowton/fix/notice-self-sufficient-mvnw

Java: Add tests for Maven wrapper

Author: smowton

java/integration-tests-lib/maven_wrapper_test_utils.py

@@ -0,0 +1,12 @@
+import sys
+import os.path
+
+def check_maven_wrapper_exists(expected_version):
+  if not os.path.exists(".mvn/wrapper/maven-wrapper.jar"):
+    print("Maven wrapper jar file expected but not found", file = sys.stderr)
+    sys.exit(1)
+  with open(".mvn/wrapper/maven-wrapper.properties", "r") as f:
+    content = f.read()
+    if ("apache-maven-%s-" % expected_version) not in content:
+      print("Expected Maven wrapper to fetch version %s, but actual properties file said:\n\n%s" % (expected_version, content), file = sys.stderr)
+      sys.exit(1)

java/ql/integration-tests/all-platforms/java/maven-wrapper-script-only/.gitattributes

@@ -0,0 +1,6 @@
+#
+# https://help.github.com/articles/dealing-with-line-endings/
+#
+# These are explicitly windows files and should use crlf
+*.bat           text eol=crlf
+*.cmd           text eol=crlf

java/ql/integration-tests/all-platforms/java/maven-wrapper-script-only/.mvn/wrapper/maven-wrapper.properties

@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.4/apache-maven-3.9.4-bin.zip
+wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar

java/ql/integration-tests/all-platforms/java/maven-wrapper-script-only/force_sequential_test_execution

@@ -0,0 +1 @@
+The wrapper downloading a Maven distribution multiple times in parallel is not safe.