Documentation for UnsafeCertTrustQuery

egregius313 · egregius313 · commit 59b1460c4920 · 2023-03-29T22:33:09.000-04:00
diff --git a/java/ql/lib/semmle/code/java/security/UnsafeCertTrustQuery.qll b/java/ql/lib/semmle/code/java/security/UnsafeCertTrustQuery.qll
@@ -22,6 +22,9 @@ deprecated class SslEndpointIdentificationFlowConfig extends TaintTracking::Conf
   }
 }
 
+/**
+ * A taint flow configuration for SSL connections created without a proper certificate trust configuration.
+ */
 module SslEndpointIdentificationFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof SslConnectionInit }
 
@@ -30,6 +33,9 @@ module SslEndpointIdentificationFlowConfig implements DataFlow::ConfigSig {
   predicate isBarrier(DataFlow::Node sanitizer) { sanitizer instanceof SslUnsafeCertTrustSanitizer }
 }
 
+/**
+ * Taint flow for SSL connections created without a proper certificate trust configuration.
+ */
 module SslEndpointIdentificationFlow = TaintTracking::Global<SslEndpointIdentificationFlowConfig>;
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,9 @@ deprecated class SslEndpointIdentificationFlowConfig extends TaintTracking::Conf`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`
	`25`	`+/**`
	`26`	`+ * A taint flow configuration for SSL connections created without a proper certificate trust configuration.`
	`27`	`+ */`
`25`	`28`	`module SslEndpointIdentificationFlowConfig implements DataFlow::ConfigSig {`
`26`	`29`	`predicate isSource(DataFlow::Node source) { source instanceof SslConnectionInit }`
`27`	`30`
`@@ -30,6 +33,9 @@ module SslEndpointIdentificationFlowConfig implements DataFlow::ConfigSig {`
`30`	`33`	`predicate isBarrier(DataFlow::Node sanitizer) { sanitizer instanceof SslUnsafeCertTrustSanitizer }`
`31`	`34`	`}`
`32`	`35`
	`36`	`+/**`
	`37`	`+ * Taint flow for SSL connections created without a proper certificate trust configuration.`
	`38`	`+ */`
`33`	`39`	`module SslEndpointIdentificationFlow = TaintTracking::Global<SslEndpointIdentificationFlowConfig>;`
`34`	`40`
`35`	`41`	`/**`