Java: performance fix

Author: Jami Cogswell

java/ql/lib/semmle/code/java/security/UrlForward.qll

@@ -26,10 +26,15 @@ private class DefaultUrlForwardSink extends UrlForwardSink {
 private class SpringUrlForwardPrefixSink extends UrlForwardSink {
   SpringUrlForwardPrefixSink() {
     any(SpringRequestMappingMethod srmm).polyCalls*(this.getEnclosingCallable()) and
-    this.asExpr() = any(ForwardPrefix fp).getAnAppendedExpression()
+    appendedToForwardPrefix(this)
   }
 }
 
+pragma[nomagic]
+private predicate appendedToForwardPrefix(DataFlow::ExprNode exprNode) {
+  exists(ForwardPrefix fp | exprNode.asExpr() = fp.getAnAppendedExpression())
+}
+
 private class ForwardPrefix extends InterestingPrefix {
   ForwardPrefix() { this.getStringValue() = "forward:" }